Ensure Messaging instance is usable after FIRApp's delete
#3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #3411. Test fails before the code change, and succeeds afterwards.
paulb777
reviewed
Aug 13, 2019
| @@ -52,7 +52,7 @@ device, and it is completely free. | |||
| s.dependency 'Protobuf', '~> 3.1' | |||
|
|
|||
| s.test_spec 'unit' do |unit_tests| | |||
| unit_tests.source_files = 'Example/Messaging/Tests/*.[mh]' | |||
| unit_tests.source_files = 'Example/Messaging/Tests/*.{m,h,swift}' | |||
maksymmalyhin
approved these changes
Aug 13, 2019
| import FirebaseMessaging | ||
| import XCTest | ||
|
|
||
| class FIRMessagingInstanceTest: XCTestCase { |
There was a problem hiding this comment.
Nice, tests in Swift!
paulb777
approved these changes
Aug 14, 2019
|
Add to release notes and bug to milestone if this fix is going in M54 (6.7.0) cc: @chliangGoogle |
|
@chliangGoogle does this make sense that |
charlotteliang
approved these changes
Aug 14, 2019
charlotteliang
requested changes
Aug 14, 2019
Done! |
paulb777
reviewed
Aug 14, 2019
Firebase/Messaging/CHANGELOG.md
Outdated
| @@ -1,6 +1,7 @@ | |||
| # 2019-08-20 -- v4.1.3 | |||
| - [changed] Cleaned up the documents, unused macros, and folders. (#3490, #3537, #3556, #3498) | |||
| - [changed] Updated the header path to pod repo relative. (#3527) | |||
| - [fixed] Fix singleton functionality after a FirebaseApp is deleted and recreated. (#3579) | |||
charlotteliang
approved these changes
Aug 14, 2019
|
Building the swift file fails with the --use-libraries test in the cron job. https://travis-ci.org/firebase/firebase-ios-sdk/jobs/572152503 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3411. Test fails before the code change, and succeeds
afterwards.