[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress server errors in deleteToken request #2428

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Suppress server errors in deleteToken request #2428

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
118b267
Suppress server errors in deleteToken request
mmermerkaya Dec 10, 2019
302c212
Update tests
mmermerkaya Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Suppress server errors in deleteToken request
  • Loading branch information
@mmermerkaya
mmermerkaya committed Dec 10, 2019
commit 118b2676fb17f87450ad6df22607ab8e9c024bd2
7 changes: 6 additions & 1 deletion packages/messaging/src/controllers/base-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,12 @@ export abstract class BaseController
*/
private async deleteTokenFromDB(token: string): Promise<void> {
const tokenDetails = await this.tokenDetailsModel.deleteToken(token);
await this.subscriptionManager.deleteToken(this.services, tokenDetails);
try {
await this.subscriptionManager.deleteToken(this.services, tokenDetails);
} catch (e) {
mmermerkaya marked this conversation as resolved.
Show resolved Hide resolved
// A failed server-side delete does not need to break the app.
mmermerkaya marked this conversation as resolved.
Show resolved Hide resolved
console.error(e);
}
}

// Visible for testing
Expand Down