[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove meaningless return statement #420

Closed
wants to merge 1 commit into from

Conversation

merlinnot
Copy link
Contributor

Simplifies one of the integrations tests in a firestore module.

See #408

Simplifies one of the integrations tests in a firestore module.
@mikelehen
Copy link
Contributor

Thanks for the PR! These used to be required for the code to compile (we may have been using a different Promise type definition or something), and so we have these return statements all over. Would you be interested in removing all of them, or at least the rest of the ones in this file? Else I can merge this as-is, but it would be best not to do this cleanup 1 line at a time. :-)

@merlinnot
Copy link
Contributor Author

Y, I’ll do that.

@merlinnot
Copy link
Contributor Author

Closing in favor of #422 which is made against master

@merlinnot merlinnot closed this Jan 10, 2018
@merlinnot merlinnot deleted the patch-1 branch January 10, 2018 12:51
@firebase firebase locked and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants