Allow type T in WithFieldValue<T> #5675

thebrianchen · 2021-10-28T15:45:05Z

Fixes #5661. Thanks @gustavohenke for proactively bringing up the fix!

This change allows developers to pass an object of type T into WithFieldValue<T>.

changeset-bot · 2021-10-28T15:45:08Z

🦋 Changeset detected

Latest commit: f2acddc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/firestore	Minor
firebase	Minor
@firebase/firestore-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2021-10-28T16:19:29Z

Size Analysis Report

Affected Products

`@firebase/app-check`

CustomProvider
Size Table
Type Base (4594d3f) Head (082d185) Diff
size
7.31 kB
7.24 kB
-68 B (-0.9%)
size-with-ext-deps
16.9 kB
16.9 kB
-69 B (-0.4%)

`ReCaptchaEnterpriseProvider`

Size Table

Type	Base (`4594d3f`)	Head (`082d185`)	Diff
size	?	9.51 kB	? (?)
size-with-ext-deps	?	18.7 kB	? (?)

Dependency Table

Type	Base (`4594d3f`)	Head (`082d185`)	Diff
functions	?	29 dependencies addTokenListener computeKey createTokenRefresher ensureActivated exchangeToken factory formatDummyToken getDBPromise getExchangeRecaptchaEnterpriseTokenRequest getRecaptcha getState getToken$1 getToken$2 initializeEnterprise internalFactory isValid loadReCAPTCHAEnterpriseScript makeDiv makeDummyTokenResult notifyTokenListeners queueWidgetRender registerAppCheck removeTokenListener renderInvisibleWidget setState sleep write writeTokenToIndexedDB writeTokenToStorage	?
classes	?	AppCheckService ReCaptchaEnterpriseProvider Refresher	?
variables	?	18 dependencies APP_CHECK_NAME APP_CHECK_NAME_INTERNAL APP_CHECK_STATES BASE_ENDPOINT DB_NAME DB_VERSION DEFAULT_STATE ERRORS ERROR_FACTORY EXCHANGE_RECAPTCHA_ENTERPRISE_TOKEN_METHOD RECAPTCHA_ENTERPRISE_URL STORE_NAME TOKEN_REFRESH_TIME dbPromise defaultTokenErrorData logger name version	?
enums	?		?

External Dependency Table

Module	Base (`4594d3f`)	Head (`082d185`)	Diff
`@firebase/app`	?	_getProvider _registerComponent registerVersion	?
`@firebase/component`	?	Component	?
`@firebase/util`	?	Deferred ErrorFactory base64 isIndexedDBAvailable	?
`@firebase/logger`	?	Logger	?

`ReCaptchaV3Provider`

Size Table

Type	Base (`4594d3f`)	Head (`082d185`)	Diff
size	9.44 kB	9.48 kB	+38 B (+0.4%)
size-with-ext-deps	18.7 kB	18.7 kB	+36 B (+0.2%)

Dependency Table

Type Base (4594d3f) Head (082d185) Diff

functions

27 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getExchangeRecaptchaTokenRequest
getRecaptcha
getState
getToken$1
getToken$2
initialize
internalFactory
isValid
loadReCAPTCHAScript
makeDummyTokenResult
notifyTokenListeners
registerAppCheck
removeTokenListener
renderInvisibleWidget
setState
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

29 dependencies

addTokenListener
computeKey
createTokenRefresher
ensureActivated
exchangeToken
factory
formatDummyToken
getDBPromise
getExchangeRecaptchaV3TokenRequest
getRecaptcha
getState
getToken$1
getToken$2
initializeV3
internalFactory
isValid
loadReCAPTCHAV3Script
makeDiv
makeDummyTokenResult
notifyTokenListeners
queueWidgetRender
registerAppCheck
removeTokenListener
renderInvisibleWidget
setState
sleep
write
writeTokenToIndexedDB
writeTokenToStorage

+ getExchangeRecaptchaV3TokenRequest
+ initializeV3
+ loadReCAPTCHAV3Script
+ makeDiv
+ queueWidgetRender
- getExchangeRecaptchaTokenRequest
- initialize
- loadReCAPTCHAScript

@firebase/auth
- ActionCodeURL
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.8 kB
  30.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.9 kB
  43.0 kB
  +84 B (+0.2%)
- AuthCredential
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.0 kB
  30.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.9 kB
  42.0 kB
  +84 B (+0.2%)
- EmailAuthCredential
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  31.9 kB
  32.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.8 kB
  43.9 kB
  +84 B (+0.2%)
- EmailAuthProvider
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  33.3 kB
  33.4 kB
  +84 B (+0.3%)
  size-with-ext-deps
  45.5 kB
  45.5 kB
  +84 B (+0.2%)
- FacebookAuthProvider
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  34.9 kB
  35.0 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.8 kB
  46.9 kB
  +84 B (+0.2%)
- GithubAuthProvider
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  34.9 kB
  35.0 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.8 kB
  46.9 kB
  +84 B (+0.2%)
- GoogleAuthProvider
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  34.9 kB
  35.0 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.8 kB
  46.9 kB
  +84 B (+0.2%)
- OAuthCredential
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  32.0 kB
  32.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.9 kB
  44.0 kB
  +84 B (+0.2%)
- OAuthProvider
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  35.9 kB
  36.0 kB
  +84 B (+0.2%)
  size-with-ext-deps
  47.7 kB
  47.8 kB
  +84 B (+0.2%)
- PhoneAuthCredential
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  32.0 kB
  32.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.9 kB
  44.0 kB
  +84 B (+0.2%)
- PhoneAuthProvider
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  33.7 kB
  33.8 kB
  +84 B (+0.2%)
  size-with-ext-deps
  45.6 kB
  45.7 kB
  +84 B (+0.2%)
- PhoneMultiFactorGenerator
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.7 kB
  30.8 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.6 kB
  42.7 kB
  +84 B (+0.2%)
- RecaptchaVerifier
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  36.2 kB
  36.3 kB
  +84 B (+0.2%)
  size-with-ext-deps
  48.1 kB
  48.1 kB
  +84 B (+0.2%)
- SAMLAuthProvider
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  36.2 kB
  36.3 kB
  +84 B (+0.2%)
  size-with-ext-deps
  48.1 kB
  48.2 kB
  +84 B (+0.2%)
- TwitterAuthProvider
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  34.9 kB
  35.0 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.8 kB
  46.9 kB
  +84 B (+0.2%)
- applyActionCode
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.0 kB
  30.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.9 kB
  41.9 kB
  +84 B (+0.2%)
- checkActionCode
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.9 kB
  31.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.8 kB
  42.9 kB
  +84 B (+0.2%)
- confirmPasswordReset
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.0 kB
  30.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.9 kB
  42.0 kB
  +84 B (+0.2%)
- connectAuthEmulator
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  31.5 kB
  31.6 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.4 kB
  43.4 kB
  +84 B (+0.2%)
- createUserWithEmailAndPassword
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.9 kB
  31.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.8 kB
  42.8 kB
  +84 B (+0.2%)
- deleteUser
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.7 kB
  +84 B (+0.2%)
- fetchSignInMethodsForEmail
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.2 kB
  30.3 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.1 kB
  42.2 kB
  +84 B (+0.2%)
- getAdditionalUserInfo
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  31.1 kB
  31.2 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.0 kB
  43.0 kB
  +84 B (+0.2%)
- getAuth
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  61.7 kB
  61.8 kB
  +84 B (+0.1%)
  size-with-ext-deps
  74.2 kB
  74.3 kB
  +84 B (+0.1%)
- getIdToken
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.7 kB
  +84 B (+0.2%)
- getIdTokenResult
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.7 kB
  29.8 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.6 kB
  41.7 kB
  +84 B (+0.2%)
- getMultiFactorResolver
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  32.5 kB
  32.6 kB
  +84 B (+0.3%)
  size-with-ext-deps
  44.4 kB
  44.4 kB
  +84 B (+0.2%)
- getRedirectResult
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  37.4 kB
  37.5 kB
  +84 B (+0.2%)
  size-with-ext-deps
  49.3 kB
  49.4 kB
  +84 B (+0.2%)
- initializeAuth
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.0 kB
  30.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.2 kB
  42.3 kB
  +84 B (+0.2%)
- isSignInWithEmailLink
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  31.0 kB
  31.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.1 kB
  43.1 kB
  +84 B (+0.2%)
- linkWithCredential
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.8 kB
  30.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.7 kB
  42.7 kB
  +84 B (+0.2%)
- linkWithPhoneNumber
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  34.5 kB
  34.5 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.4 kB
  46.4 kB
  +84 B (+0.2%)
- linkWithPopup
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  41.0 kB
  41.1 kB
  +84 B (+0.2%)
  size-with-ext-deps
  52.9 kB
  53.0 kB
  +84 B (+0.2%)
- linkWithRedirect
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  36.2 kB
  36.3 kB
  +84 B (+0.2%)
  size-with-ext-deps
  48.1 kB
  48.1 kB
  +84 B (+0.2%)
- multiFactor
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  32.0 kB
  32.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.8 kB
  43.9 kB
  +84 B (+0.2%)
- onAuthStateChanged
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.8 kB
  +84 B (+0.2%)
- onIdTokenChanged
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.8 kB
  +84 B (+0.2%)
- parseActionCodeURL
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.9 kB
  31.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.0 kB
  43.1 kB
  +84 B (+0.2%)
- reauthenticateWithCredential
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  31.4 kB
  31.4 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.2 kB
  43.3 kB
  +84 B (+0.2%)
- reauthenticateWithPhoneNumber
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  35.0 kB
  35.1 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.9 kB
  47.0 kB
  +84 B (+0.2%)
- reauthenticateWithPopup
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  41.0 kB
  41.1 kB
  +84 B (+0.2%)
  size-with-ext-deps
  52.9 kB
  53.0 kB
  +84 B (+0.2%)
- reauthenticateWithRedirect
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  35.9 kB
  36.0 kB
  +84 B (+0.2%)
  size-with-ext-deps
  47.8 kB
  47.9 kB
  +84 B (+0.2%)
- reload
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.7 kB
  29.8 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.6 kB
  41.7 kB
  +84 B (+0.2%)
- sendEmailVerification
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.8 kB
  30.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.7 kB
  42.8 kB
  +84 B (+0.2%)
- sendPasswordResetEmail
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.7 kB
  30.8 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.6 kB
  42.7 kB
  +84 B (+0.2%)
- sendSignInLinkToEmail
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.8 kB
  30.8 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.6 kB
  42.7 kB
  +84 B (+0.2%)
- setPersistence
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.7 kB
  +84 B (+0.2%)
- signInAnonymously
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  31.0 kB
  31.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.9 kB
  43.0 kB
  +84 B (+0.2%)
- signInWithCredential
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  31.1 kB
  31.2 kB
  +84 B (+0.3%)
  size-with-ext-deps
  43.0 kB
  43.1 kB
  +84 B (+0.2%)
- signInWithCustomToken
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.9 kB
  31.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.8 kB
  42.8 kB
  +84 B (+0.2%)
- signInWithEmailAndPassword
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  34.8 kB
  34.9 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.9 kB
  47.0 kB
  +84 B (+0.2%)
- signInWithEmailLink
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  35.0 kB
  35.1 kB
  +84 B (+0.2%)
  size-with-ext-deps
  47.1 kB
  47.2 kB
  +84 B (+0.2%)
- signInWithPhoneNumber
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  34.8 kB
  34.9 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.7 kB
  46.8 kB
  +84 B (+0.2%)
- signInWithPopup
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  41.0 kB
  41.1 kB
  +84 B (+0.2%)
  size-with-ext-deps
  52.9 kB
  53.0 kB
  +84 B (+0.2%)
- signInWithRedirect
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  35.6 kB
  35.7 kB
  +84 B (+0.2%)
  size-with-ext-deps
  47.5 kB
  47.6 kB
  +84 B (+0.2%)
- signOut
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.6 kB
  41.7 kB
  +84 B (+0.2%)
- unlink
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.4 kB
  30.4 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.2 kB
  42.3 kB
  +84 B (+0.2%)
- updateCurrentUser
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.8 kB
  +84 B (+0.2%)
- updateEmail
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.1 kB
  30.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.9 kB
  42.0 kB
  +84 B (+0.2%)
- updatePassword
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.1 kB
  30.2 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.9 kB
  42.0 kB
  +84 B (+0.2%)
- updatePhoneNumber
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.5 kB
  30.6 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.4 kB
  42.5 kB
  +84 B (+0.2%)
- updateProfile
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.3 kB
  30.3 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.1 kB
  42.2 kB
  +84 B (+0.2%)
- useDeviceLanguage
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.7 kB
  +84 B (+0.2%)
- verifyBeforeUpdateEmail
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.8 kB
  30.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.7 kB
  42.8 kB
  +84 B (+0.2%)
- verifyPasswordResetCode
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  31.0 kB
  31.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  42.9 kB
  43.0 kB
  +84 B (+0.2%)
- ActionCodeOperation
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  30.0 kB
  30.1 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.9 kB
  41.9 kB
  +84 B (+0.2%)
- AuthErrorCodes
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  34.4 kB
  34.5 kB
  +84 B (+0.2%)
  size-with-ext-deps
  46.3 kB
  46.4 kB
  +84 B (+0.2%)
- FactorId
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.6 kB
  41.7 kB
  +84 B (+0.2%)
- OperationType
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.8 kB
  29.9 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.8 kB
  +84 B (+0.2%)
- ProviderId
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.9 kB
  30.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.7 kB
  41.8 kB
  +84 B (+0.2%)
- SignInMethod
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.9 kB
  30.0 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.8 kB
  41.9 kB
  +84 B (+0.2%)
- browserLocalPersistence
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  33.1 kB
  33.2 kB
  +84 B (+0.3%)
  size-with-ext-deps
  45.1 kB
  45.2 kB
  +84 B (+0.2%)
- browserPopupRedirectResolver
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  54.0 kB
  54.1 kB
  +84 B (+0.2%)
  size-with-ext-deps
  66.1 kB
  66.1 kB
  +84 B (+0.1%)
- browserSessionPersistence
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  33.1 kB
  33.2 kB
  +84 B (+0.3%)
  size-with-ext-deps
  45.1 kB
  45.2 kB
  +84 B (+0.2%)
- debugErrorMap
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  40.8 kB
  40.9 kB
  +84 B (+0.2%)
  size-with-ext-deps
  52.7 kB
  52.8 kB
  +84 B (+0.2%)
- inMemoryPersistence
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.8 kB
  29.8 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.6 kB
  41.7 kB
  +84 B (+0.2%)
- indexedDBLocalPersistence
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  37.2 kB
  37.3 kB
  +84 B (+0.2%)
  size-with-ext-deps
  49.1 kB
  49.1 kB
  +84 B (+0.2%)
- prodErrorMap
  Size Table
  Type Base (4594d3f) Head (082d185) Diff
  size
  29.7 kB
  29.8 kB
  +84 B (+0.3%)
  size-with-ext-deps
  41.6 kB
  41.7 kB
  +84 B (+0.2%)

Test Logs

schmidt-sebastian · 2021-10-28T21:41:54Z

packages/firestore/test/lite/integration.test.ts

+        class ObjectWrapper<T> {
+          withFieldValueT(value: WithFieldValue<T>): void {
+            // eslint-disable-next-line no-console
+            console.log(value);


Do we need to log here?

schmidt-sebastian · 2021-10-28T21:45:01Z

packages/firestore/src/lite-api/reference.ts

+      ? T
+      : T extends {}
+      ? { [K in keyof T]: WithFieldValue<T[K]> | FieldValue }
+      : Partial<T>);


Unrelated to this PR, but why do we allow Partial here? Does that mean a user can omit properties as long as they are nested?

This should technically be never. Fixed.

google-oss-bot · 2021-11-02T05:28:56Z

Binary Size Report

Affected SDKs

`@firebase/app-check`

Type	Base (`4594d3f`)	Head (`082d185`)	Diff
browser	20.4 kB	22.3 kB	+1.95 kB (+9.6%)
esm5	24.3 kB	26.6 kB	+2.36 kB (+9.7%)
main	25.3 kB	27.8 kB	+2.53 kB (+10.0%)
module	20.4 kB	22.3 kB	+1.95 kB (+9.6%)

`@firebase/app-check-compat`

Type	Base (`4594d3f`)	Head (`082d185`)	Diff
browser	2.13 kB	2.27 kB	+142 B (+6.7%)
esm5	2.33 kB	2.48 kB	+142 B (+6.1%)
main	2.81 kB	2.94 kB	+132 B (+4.7%)
module	2.13 kB	2.27 kB	+142 B (+6.7%)

@firebase/auth-compat

Type Base (4594d3f) Head (082d185) Diff

browser 19.7 kB 19.8 kB +38 B (+0.2%)

esm5 26.6 kB 26.6 kB +38 B (+0.1%)

main 29.1 kB 29.1 kB +49 B (+0.2%)

module 19.7 kB 19.8 kB +38 B (+0.2%)
@firebase/auth/cordova

Type Base (4594d3f) Head (082d185) Diff

browser 179 kB 179 kB +88 B (+0.0%)

module 179 kB 179 kB +88 B (+0.0%)
@firebase/auth/internal

Type Base (4594d3f) Head (082d185) Diff

browser 163 kB 163 kB +88 B (+0.1%)

esm5 211 kB 211 kB +88 B (+0.0%)

main 179 kB 179 kB +88 B (+0.0%)

module 163 kB 163 kB +88 B (+0.1%)
@firebase/auth/react-native

Type Base (4594d3f) Head (082d185) Diff

browser 162 kB 162 kB +88 B (+0.1%)

module 162 kB 162 kB +88 B (+0.1%)

`firebase`

Type	Base (`4594d3f`)	Head (`082d185`)	Diff
firebase-app-check-compat.js	20.0 kB	20.9 kB	+926 B (+4.6%)
firebase-app-check.js	77.6 kB	80.6 kB	+2.95 kB (+3.8%)
firebase-auth-compat.js	122 kB	123 kB	+616 B (+0.5%)
firebase-auth-cordova.js	460 kB	460 kB	+131 B (+0.0%)
firebase-auth-react-native.js	479 kB	479 kB	+131 B (+0.0%)
firebase-auth.js	410 kB	410 kB	+119 B (+0.0%)
firebase-compat.js	751 kB	752 kB	+1.54 kB (+0.2%)

Test Logs

Base (4594d3fd): https://github.com/firebase/firebase-js-sdk/actions/runs/1392186344
Head (082d185d): https://github.com/firebase/firebase-js-sdk/actions/runs/1414327801

.changeset/short-mice-itch.md

egilmorez

Found one typo, otherwise LGTM!

(Reviewing for Mark, who is out today)

egilmorez · 2021-11-02T21:44:51Z

.changeset/short-mice-itch.md

+'@firebase/firestore': minor
+---
+
+Expanded `Firestore.WithFieldValue<T>` to include `T`. This allows developers to delegate `WithFieldValue<T>` inside a wrappers of type `T` to avoid exposing Firebase types beyond Firebase-specific logic.


I think "a wrappers" should just be "wrappers"

done. thanks for catching

Co-authored-by: Feiyang <feiyangc@google.com>

…dk into bc/withfieldvalue

Allow type T in WithFieldValue<T>

1450b76

thebrianchen requested review from egilmorez, Feiyang1, hiranya911 and hsubox76 as code owners October 28, 2021 15:45

google-cla bot added the cla: yes label Oct 28, 2021

thebrianchen assigned thebrianchen and schmidt-sebastian and unassigned thebrianchen Oct 28, 2021

thebrianchen requested a review from schmidt-sebastian October 28, 2021 16:17

schmidt-sebastian reviewed Oct 28, 2021

View reviewed changes

schmidt-sebastian assigned thebrianchen and unassigned schmidt-sebastian Oct 28, 2021

egilmorez requested a review from markarndt November 1, 2021 18:33

Brian Chen added 2 commits November 1, 2021 22:07

add more tests and fix PartialWithFieldValue

8af2407

update md files

4f84138

google-oss-bot added the doc-changes PRs that affect docs label Nov 2, 2021

github-actions bot assigned egilmorez Nov 2, 2021

thebrianchen assigned schmidt-sebastian and unassigned thebrianchen and egilmorez Nov 2, 2021

thebrianchen requested a review from schmidt-sebastian November 2, 2021 14:55

add comments to test

ea1cbd6

schmidt-sebastian approved these changes Nov 2, 2021

View reviewed changes

schmidt-sebastian removed their assignment Nov 2, 2021

thebrianchen assigned Feiyang1 Nov 2, 2021

Feiyang1 suggested changes Nov 2, 2021

View reviewed changes

.changeset/short-mice-itch.md Show resolved Hide resolved

Feiyang1 assigned thebrianchen and unassigned Feiyang1 Nov 2, 2021

egilmorez approved these changes Nov 2, 2021

View reviewed changes

Brian Chen and others added 3 commits November 2, 2021 15:01

Update .changeset/short-mice-itch.md

e219327

Co-authored-by: Feiyang <feiyangc@google.com>

fix changeset grammar

b03e7a3

Merge branch 'bc/withfieldvalue' of github.com:firebase/firebase-js-s…

f2acddc

…dk into bc/withfieldvalue

thebrianchen requested a review from Feiyang1 November 2, 2021 22:19

thebrianchen assigned Feiyang1 and unassigned thebrianchen Nov 2, 2021

Feiyang1 approved these changes Nov 3, 2021

View reviewed changes

Feiyang1 assigned thebrianchen and unassigned Feiyang1 Nov 3, 2021

thebrianchen merged commit 532b3cd into master Nov 3, 2021

thebrianchen deleted the bc/withfieldvalue branch November 3, 2021 17:09

thebrianchen mentioned this pull request Nov 3, 2021

feat: allow type T in WithFieldValue<T> googleapis/nodejs-firestore#1626

Merged

google-oss-bot mentioned this pull request Nov 8, 2021

Version Packages #5710

Merged

firebase locked and limited conversation to collaborators Dec 4, 2021

Allow type T in WithFieldValue<T> #5675

Allow type T in WithFieldValue<T> #5675

Conversation

🦋 Changeset detected

Size Analysis Report

Affected Products

@firebase/app-check

CustomProvider

ReCaptchaEnterpriseProvider

ReCaptchaV3Provider

@firebase/auth

ActionCodeURL

AuthCredential

EmailAuthCredential

EmailAuthProvider

FacebookAuthProvider

GithubAuthProvider

GoogleAuthProvider

OAuthCredential

OAuthProvider

PhoneAuthCredential

PhoneAuthProvider

PhoneMultiFactorGenerator

RecaptchaVerifier

SAMLAuthProvider

TwitterAuthProvider

applyActionCode

checkActionCode

confirmPasswordReset

connectAuthEmulator

createUserWithEmailAndPassword

deleteUser

fetchSignInMethodsForEmail

getAdditionalUserInfo

getAuth

getIdToken

getIdTokenResult

getMultiFactorResolver

getRedirectResult

initializeAuth

isSignInWithEmailLink

linkWithCredential

linkWithPhoneNumber

linkWithPopup

linkWithRedirect

multiFactor

onAuthStateChanged

onIdTokenChanged

parseActionCodeURL

reauthenticateWithCredential

reauthenticateWithPhoneNumber

reauthenticateWithPopup

reauthenticateWithRedirect

reload

sendEmailVerification

sendPasswordResetEmail

sendSignInLinkToEmail

setPersistence

signInAnonymously

signInWithCredential

signInWithCustomToken

signInWithEmailAndPassword

signInWithEmailLink

signInWithPhoneNumber

signInWithPopup

signInWithRedirect

signOut

unlink

updateCurrentUser

updateEmail

updatePassword

updatePhoneNumber

updateProfile

useDeviceLanguage

verifyBeforeUpdateEmail

verifyPasswordResetCode

ActionCodeOperation

AuthErrorCodes

FactorId

OperationType

`@firebase/app-check`

`CustomProvider`

`ReCaptchaEnterpriseProvider`

`ReCaptchaV3Provider`

`@firebase/auth`

`ActionCodeURL`

`AuthCredential`

`EmailAuthCredential`

`EmailAuthProvider`

`FacebookAuthProvider`

`GithubAuthProvider`

`GoogleAuthProvider`

`OAuthCredential`

`OAuthProvider`

`PhoneAuthCredential`

`PhoneAuthProvider`

`PhoneMultiFactorGenerator`

`RecaptchaVerifier`

`SAMLAuthProvider`

`TwitterAuthProvider`

`applyActionCode`

`checkActionCode`

`confirmPasswordReset`

`connectAuthEmulator`

`createUserWithEmailAndPassword`

`deleteUser`

`fetchSignInMethodsForEmail`

`getAdditionalUserInfo`

`getAuth`

`getIdToken`

`getIdTokenResult`

`getMultiFactorResolver`

`getRedirectResult`

`initializeAuth`

`isSignInWithEmailLink`

`linkWithCredential`

`linkWithPhoneNumber`

`linkWithPopup`

`linkWithRedirect`

`multiFactor`

`onAuthStateChanged`

`onIdTokenChanged`

`parseActionCodeURL`

`reauthenticateWithCredential`

`reauthenticateWithPhoneNumber`

`reauthenticateWithPopup`

`reauthenticateWithRedirect`

`reload`

`sendEmailVerification`

`sendPasswordResetEmail`

`sendSignInLinkToEmail`

`setPersistence`

`signInAnonymously`

`signInWithCredential`

`signInWithCustomToken`

`signInWithEmailAndPassword`

`signInWithEmailLink`

`signInWithPhoneNumber`

`signInWithPopup`

`signInWithRedirect`

`signOut`

`unlink`

`updateCurrentUser`

`updateEmail`

`updatePassword`

`updatePhoneNumber`

`updateProfile`

`useDeviceLanguage`

`verifyBeforeUpdateEmail`

`verifyPasswordResetCode`

`ActionCodeOperation`

`AuthErrorCodes`

`FactorId`

`OperationType`

`ProviderId`

`SignInMethod`

`browserLocalPersistence`

`browserPopupRedirectResolver`

`browserSessionPersistence`

`debugErrorMap`