[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the totp assertion files into src/mfa/assertions/ #6602

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Move the totp assertion files into src/mfa/assertions/ #6602

merged 1 commit into from
Sep 16, 2022

Conversation

prameshj
Copy link
Contributor

The mfa/assertions/totp directory was accidentally created.

@changeset-bot
Copy link
changeset-bot bot commented Sep 15, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 28c6125

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Sep 15, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (9c6e780) and merge commit (0a685ff).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/YRKbAkt5XH.html

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Sep 15, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

No changes between base commit (9c6e780) and merge commit (0a685ff).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kigQvJCf0o.html

@prameshj prameshj force-pushed the mfa-totp-prameshj branch 2 times, most recently from 31b71fa to 3df8ac9 Compare September 16, 2022 19:17
@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Changeset formatting error in following file: 
    Some packages have been changed but no changesets were found. Run `changeset add` to resolve this error.
If this change doesn't need a release, run `changeset add --empty`.

@prameshj
restore totp*.ts into mfa/assertions directory.
28c6125 
The same pattern is followed in rest of the auth codebase. (ex- src/platform_browser/mfa/assertions/)
@prameshj prameshj merged commit 70cbc31 into mfa-totp Sep 16, 2022
@prameshj prameshj deleted the mfa-totp-prameshj branch September 16, 2022 21:16
bhparijat pushed a commit that referenced this pull request Sep 23, 2022
@prameshj @bhparijat
restore totp*.ts into mfa/assertions directory. (#6602)
f9f292b 
The same pattern is followed in rest of the auth codebase. (ex- src/platform_browser/mfa/assertions/)
bhparijat pushed a commit that referenced this pull request Sep 23, 2022
@prameshj @bhparijat
restore totp*.ts into mfa/assertions directory. (#6602)
3a4afda 
The same pattern is followed in rest of the auth codebase. (ex- src/platform_browser/mfa/assertions/)
bhparijat pushed a commit that referenced this pull request Oct 11, 2022
@prameshj @bhparijat
restore totp*.ts into mfa/assertions directory. (#6602)
3e8af6d 
The same pattern is followed in rest of the auth codebase. (ex- src/platform_browser/mfa/assertions/)
bhparijat pushed a commit that referenced this pull request Oct 13, 2022
@prameshj @bhparijat
restore totp*.ts into mfa/assertions directory. (#6602)
f3741eb 
The same pattern is followed in rest of the auth codebase. (ex- src/platform_browser/mfa/assertions/)
@firebase firebase locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi is a code owner

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@yuchenshi yuchenshi Awaiting requested review from yuchenshi yuchenshi is a code owner

@egilmorez egilmorez Awaiting requested review from egilmorez

@hsubox76 hsubox76 Awaiting requested review from hsubox76

@erikeldridge erikeldridge Awaiting requested review from erikeldridge

@jposuna jposuna Awaiting requested review from jposuna

@yoyomyo yoyomyo Awaiting requested review from yoyomyo

@zwu52 zwu52 Awaiting requested review from zwu52

@maneesht maneesht Awaiting requested review from maneesht

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang

@jsdt jsdt Awaiting requested review from jsdt

@jmwski jmwski Awaiting requested review from jmwski

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prameshj @google-oss-bot @sam-gc