[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bloom filter to existence filter and watchFilters spec builder #6839

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Add bloom filter to existence filter and watchFilters spec builder #6839

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d6d92b
add bloom filter to existence filter, and watchFilters spec builder
milaGGL Nov 30, 2022
b02d4a9
remove 'exclusive'
milaGGL Nov 30, 2022
0b76b5e
resolve comments
milaGGL Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
resolve comments
  • Loading branch information
@milaGGL
milaGGL committed Nov 30, 2022
commit 0b76b5e76f2f0eb7ee38a64e1b534fcc78070ff2
3 changes: 1 addition & 2 deletions packages/firestore/src/protos/firestore_proto_api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,8 +456,7 @@ export declare type BeginTransactionRequest =
firestoreV1ApiClientInterfaces.BeginTransactionRequest;
export declare type BeginTransactionResponse =
firestoreV1ApiClientInterfaces.BeginTransactionResponse;
export declare type BloomFilter =
firestoreV1ApiClientInterfaces.BloomFilter;
export declare type BloomFilter = firestoreV1ApiClientInterfaces.BloomFilter;
export declare type CollectionSelector =
firestoreV1ApiClientInterfaces.CollectionSelector;
export declare type CommitRequest =
Expand Down
1 change: 0 additions & 1 deletion packages/firestore/src/remote/existence_filter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,5 @@
import { BloomFilter as ProtoBloomFilter } from '../protos/firestore_proto_api';

export class ExistenceFilter {
// TODO(b/33078163): just use simplest form of existence filter for now
constructor(public count: number, public unchangedNames?: ProtoBloomFilter) {}
dconeybe marked this conversation as resolved.
Show resolved Hide resolved
}