[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MFA TOTP in web SDK #7146

Merged
merged 26 commits into from
Mar 28, 2023
Merged

Support MFA TOTP in web SDK #7146

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
ebbf397
adding support TOTP MFA (#6547)
bhparijat Aug 31, 2022
c79e7fb
Implement TOTP MFA enrollment flows (#6598)
prameshj Sep 14, 2022
e11ed0b
restore totp*.ts into mfa/assertions directory. (#6602)
prameshj Sep 16, 2022
524f1d1
Demo-app readme fix (#6630)
bhparijat Sep 28, 2022
b6c736f
Mfa totp demoapp (#6629)
prameshj Oct 5, 2022
e3f2bea
sign-in flow for totp (#6626)
bhparijat Oct 13, 2022
59e6da3
Unit test cases for sign-in flow (#6640)
bhparijat Oct 14, 2022
7310822
integration tests for totp (#6784)
bhparijat Nov 22, 2022
07eacac
Totp integration test fix (#6814)
bhparijat Dec 3, 2022
36fc7c7
fixing conflict in package.json (#6855)
bhparijat Dec 5, 2022
3c64cc7
Fix mfa totp unit test (#6858)
prameshj Dec 7, 2022
1fcf4e1
Added ui for setting tenant-id (#6850)
bhparijat Dec 7, 2022
5ff2929
Expose enrollmentCompletionDeadline field in TotpSecret. (#6870)
prameshj Dec 27, 2022
b00a7ae
clear TOTP QR code display in the demo app once enrollment is complet…
prameshj Jan 28, 2023
119cb1c
Add a command to run totp integration tests. (#6998)
prameshj Feb 15, 2023
522392a
remove startMfaSignIn step for TOTP. (#7047)
prameshj Feb 22, 2023
2ab3198
Add back totp-generator dep (removed during merge conflict)
prameshj Mar 22, 2023
df20c0a
Fix doc comments in TOTP files
prameshj Mar 28, 2023
0972c84
Generate docs for TOTP
prameshj Mar 28, 2023
b13870c
Add changeset
prameshj Mar 28, 2023
8c158e8
Update packages/auth/src/mfa/assertions/totp.ts
prameshj Mar 28, 2023
5e73e41
Update packages/auth/src/model/public_types.ts
prameshj Mar 28, 2023
be27f0b
Update packages/auth/src/mfa/assertions/totp.ts
prameshj Mar 28, 2023
81c3177
Update packages/auth/src/mfa/assertions/totp.ts
prameshj Mar 28, 2023
a507d93
Apply suggestions from code review
prameshj Mar 28, 2023
7c2af18
re-generate docs
prameshj Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/auth/src/mfa/assertions/totp.ts 
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
  • Loading branch information
@prameshj @kevinthecheung
prameshj and kevinthecheung committed Mar 28, 2023
commit be27f0bd062ca6f937cc3d61beff8a4942e368d3
8 changes: 4 additions & 4 deletions packages/auth/src/mfa/assertions/totp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,14 +244,14 @@ export class TotpSecret {
}

/**
* Returns a QRCode URL as described in
* Returns a QR code URL as described in
* https://github.com/google/google-authenticator/wiki/Key-Uri-Format
* This can be displayed to the user as a QRCode to be scanned into a TOTP App like Google Authenticator.
* This can be displayed to the user as a QR code to be scanned into a TOTP app like Google Authenticator.
* If the optional parameters are unspecified, an accountName of <userEmail> and issuer of <firebaseAppName> are used.
*
* @param accountName the name of the account/app along with a user identifier.
* @param issuer issuer of the TOTP(likely the app name).
* @returns A QRCode URL string.
* @param issuer issuer of the TOTP (likely the app name).
* @returns A QR code URL string.
*/
generateQrCodeUrl(accountName?: string, issuer?: string): string {
let useDefaults = false;
Expand Down