[go: nahoru, domu]

Skip to content

Commit

Permalink
fix: add codebase config runtime to delegate context object (#6964)
Browse files Browse the repository at this point in the history
* fix: add codebase config runtime to delegate context object

* fix: add codebase config runtime to delegate context object

* docs(changelog): add entry for fixed bug detecting functions runtime

* fix: run format command

---------

Co-authored-by: Cole Rogers <colerogers@users.noreply.github.com>
  • Loading branch information
luc-mo and colerogers committed Apr 11, 2024
1 parent dcbc58e commit 61d0c30
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
- Add Firebase console link after creating or restoring a Firestore database (#6949)
- Increase supported Astro version to 4 (#6960)
- Fixes a deployment crash when resetting min instances to 0 in v1 functions (#6990)
- Fixes bug detecting functions runtime from firebase.json (#6964)
1 change: 1 addition & 0 deletions src/deploy/functions/prepare.ts
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,7 @@ export async function loadCodebases(
projectId,
sourceDir,
projectDir: options.config.projectDir,
runtime: codebaseConfig.runtime,
};
const firebaseJsonRuntime = codebaseConfig.runtime;
if (firebaseJsonRuntime && !supported.isRuntime(firebaseJsonRuntime as string)) {
Expand Down

0 comments on commit 61d0c30

Please sign in to comment.