fix async effect (#7383)

firebase · Jun 25, 2024 · 1f579c8 · 1f579c8
1 parent edb2b47
commit 1f579c8
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/firebase-vscode/src/core/project.ts b/firebase-vscode/src/core/project.ts
@@ -8,6 +8,7 @@ import { listProjects } from "../cli";
 import { pluginLogger } from "../logger-wrapper";
 import { globalSignal } from "../utils/globals";
 import { firstWhereDefined } from "../utils/signal";
+import { User } from "../types/auth";
 
 /** Available projects */
 export const projects = globalSignal<Record<string, FirebaseProjectMetadata[]>>(
@@ -43,15 +44,20 @@ export const currentProject = computed<FirebaseProjectMetadata | undefined>(
 );
 
 export function registerProject(broker: ExtensionBrokerImpl): Disposable {
-  const sub1 = effect(async () => {
-    const user = currentUser.value;
-    if (user) {
-      pluginLogger.info("(Core:Project) New user detected, fetching projects");
+
+  async function fetchNewProjects(user: User) {
       const userProjects = await listProjects();
       projects.value = {
         ...projects.value,
         [user.email]: userProjects,
       };
+  }
+
+  const sub1 = effect(() => {
+    const user = currentUser.value;
+    if (user) {
+      pluginLogger.info("(Core:Project) New user detected, fetching projects");
+      fetchNewProjects(user);
     }
   });