[go: nahoru, domu]

Skip to content

Commit

Permalink
Require firebase-functions >= 3.13.1 in functions emulator. (#3851)
Browse files Browse the repository at this point in the history
* Require firebase-functions >= 3.13.1 in functions emulator.

To include the fix in firebase/firebase-functions#838, causing a hard to debug issue when both database and functions emulators are started.

* Update CHANGELOG.md

Co-authored-by: Bryan Kendall <bkend@google.com>
  • Loading branch information
yuchenshi and bkendall committed Dec 14, 2021
1 parent 017dab4 commit a5ff8d5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@
- Fixes issue with filtering on a specific storage bucket using functions in the emulator (#3893)
- Fixes check in Cloud Functions for Firebase initialization to check for API enablement before trying to enable them. (#2574)
- No longer tries to clean up function build images from Artifact Registry when Artifact Registry is not enabled (#3943)
- Requires firebase-functions >= 3.13.1 in Functions emulator to include bug fixes (#3851).
2 changes: 1 addition & 1 deletion src/emulator/functionsEmulatorRuntime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ async function assertResolveDeveloperNodeModule(
async function verifyDeveloperNodeModules(frb: FunctionsRuntimeBundle): Promise<boolean> {
const modBundles = [
{ name: "firebase-admin", isDev: false, minVersion: "8.9.0" },
{ name: "firebase-functions", isDev: false, minVersion: "3.3.0" },
{ name: "firebase-functions", isDev: false, minVersion: "3.13.1" },
];

for (const modBundle of modBundles) {
Expand Down

0 comments on commit a5ff8d5

Please sign in to comment.