[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert FirebaseError to TypeScript #1521

Merged
merged 16 commits into from
Jul 23, 2019
Merged

Convert FirebaseError to TypeScript #1521

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
86bbdaf
Convert FirebaseError to TypeScript
merlinnot Jul 17, 2019
e245926
Use named export of FirebaseError
merlinnot Jul 17, 2019
8518891
Merge branch 'master' into error-ts
merlinnot Jul 17, 2019
c5684d8
Assign properties in FirebaseError constructor in alphabetical order
merlinnot Jul 17, 2019
026648d
Remove newlines between class properties
merlinnot Jul 17, 2019
5868765
Avoid destruction of properties
merlinnot Jul 17, 2019
5b25ee0
Add basic tests for FirestoreError
merlinnot Jul 17, 2019
af7291e
Merge branch 'master' into error-ts
merlinnot Jul 17, 2019
2505170
Merge branch 'master' into error-ts
merlinnot Jul 17, 2019
8e3886a
Rename a test file
merlinnot Jul 18, 2019
54b491a
Don't enforce all options to exist in FirebaseError class definition
merlinnot Jul 18, 2019
0aead9a
Merge branch 'master' into error-ts
merlinnot Jul 18, 2019
da733e0
Merge branch 'master' into error-ts
merlinnot Jul 23, 2019
38dd5f9
Merge branch 'master' into error-ts
merlinnot Jul 23, 2019
b1bbe9b
Describe complex typings so it is more understandable
merlinnot Jul 23, 2019
c4a0d61
Merge branch 'master' into error-ts
bkendall Jul 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid destruction of properties
  • Loading branch information
@merlinnot
merlinnot committed Jul 17, 2019
commit 5868765bee62fb0e5f365865a708f325fbc3240a
23 changes: 8 additions & 15 deletions src/error.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { defaultTo } from "lodash";

interface FirebaseErrorOptions {
merlinnot marked this conversation as resolved.
Show resolved Hide resolved
children?: unknown[];
context?: unknown;
Expand All @@ -19,23 +21,14 @@ export class FirebaseError extends Error implements FirebaseErrorOptions {
readonly original: Error | undefined;
readonly status: number;
merlinnot marked this conversation as resolved.
Show resolved Hide resolved

constructor(
message: string,
{
children = DEFAULT_CHILDREN,
context,
exit = DEFAULT_EXIT,
original,
status = DEFAULT_STATUS,
}: FirebaseErrorOptions = {}
) {
constructor(message: string, options: FirebaseErrorOptions = {}) {
super();

this.children = children;
this.context = context;
this.exit = exit;
this.children = defaultTo(options.children, DEFAULT_CHILDREN);
this.context = options.context;
this.exit = defaultTo(options.exit, DEFAULT_EXIT);
this.message = message;
this.original = original;
this.status = status;
this.original = options.original;
this.status = defaultTo(options.status, DEFAULT_STATUS);
}
}