[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for functions failure policies #1858

Merged
merged 8 commits into from
Aug 20, 2020
Merged

Support for functions failure policies #1858

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0eb9f5b
Create works, update fails
samtstern Dec 10, 2019
389dfde
Merge branch 'master' into ss-failure-policy
samtstern Aug 13, 2020
df0a447
Fix TODOs, get it all workng
samtstern Aug 13, 2020
bbd9d2e
Undo one change
samtstern Aug 13, 2020
af4ad66
Merge branch 'master' into ss-failure-policy
mbleigh Aug 18, 2020
0a12eb1
Merge branch 'master' into ss-failure-policy
samtstern Aug 20, 2020
b310649
Real dep, fixed message
samtstern Aug 20, 2020
fa8e0e7
Merge branch 'ss-failure-policy' of github.com:firebase/firebase-tool…
samtstern Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Undo one change
  • Loading branch information
@samtstern
samtstern committed Aug 13, 2020
commit bbd9d2ea3e376b1c20a19bb01aa1912d15facccb
3 changes: 1 addition & 2 deletions src/gcp/cloudfunctions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,10 @@ function _createFunction(options) {
data.environmentVariables = options.environmentVariables;
}

var dataWithTrigger = _.assign(data, options.trigger);
return api
.request("POST", endpoint, {
auth: true,
data: dataWithTrigger,
data: _.assign(data, options.trigger),
origin: api.functionsOrigin,
})
.then(
Expand Down