Prevent pipeline.js from moving standaline scripts on build #1897
Conversation
|
@samtstern snuck in a couple more fixed if you can PTAL again |
| if (isLocalFirepit) { | ||
| echo("Using local firepit for testing..."); | ||
| mkdir("firepit"); | ||
| rm("-rf", path.join(__dirname, "../vendor/node_modules")); |
There was a problem hiding this comment.
Why dont you need to rm these files anymore?
There was a problem hiding this comment.
This whole step was only used when the --local flag was used which was only helpful when this script made a distinction between local (i.e. build from current directory) and remote (build from HEAD on Github). Since this script no longer support the remote flow and now does all work in a temp directory, we can simplify this and allow the cleaning of the temp dir to do this removal.
There was a problem hiding this comment.
Ok makes sense. Can you add a comment to the top of this file explaining what flags are accepted? Since it just examines argv at different times it's kind of hard to know.
There was a minor bug in the
firepit-builderwhich made local development harder because it would remove thestandalone/folder instead of just copying it to the right place.