revamp triggers end-to-end functional test #2178
Conversation
| if (logDoneFn) { | ||
| started = new Promise((resolve) => { | ||
| this.process?.stdout.on("data", (data: unknown) => { | ||
| if (logDoneFn(data)) { |
There was a problem hiding this comment.
Could this hang forever? Shouldn't we still resolve on close?
There was a problem hiding this comment.
This block of code tricked me the first time. If we have this function, we make this resolving promise. If we don't, we do one on 'close' below.
Basically, logDoneFn looks for a string in the data that comes through and says "started" when that happens (logDoneFn is user-supplied). If that fn isn't provided, it just waits until the process closes.
There was a problem hiding this comment.
Yes but what if logDoneFn(data) never returns true? Then the function will never hit resolve()
There was a problem hiding this comment.
Gotcha. After a quick discussion, we're going to reject if logDoneFn never succeeds :)
Description
Rewriting the triggers-end-to-end tests to be in Typescript in the new form that has been working really well in other tests.