prefer arrow fns, turn off no-var
in .js
files
#2107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
no-var
checking in JS files (which silences ~1500 messages).Turning off
no-var
: since we're really trying to move to TS, I don't think it's worth being super noisy aboutvar
. New code should fix it as is required, but we're not going to go clean these up (and I don't want to automatically do it because then it touches nearly every file's history again, which is not super useful)