[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint and format markdown and yaml #2111

Merged
merged 4 commits into from
Apr 7, 2020
Merged

lint and format markdown and yaml #2111

merged 4 commits into from
Apr 7, 2020

Conversation

bkendall
Copy link
Contributor
@bkendall bkendall commented Apr 6, 2020

Description

ever think we didn't have enough auto-formatting? worry no more! now md and yaml files are formatted by prettier (and enforced by lint).

@bkendall bkendall requested a review from samtstern April 6, 2020 22:50
@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Apr 6, 2020
}).catch(function(err) {
// handle error
});
var client = require("firebase-tools");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did prettier just pretty some JS inside MD? That's next level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Yes it did. I'm not even mad.

Copy link
Contributor
@samtstern samtstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool with me.

@bkendall bkendall merged commit 4050f46 into master Apr 7, 2020
@bkendall bkendall deleted the bk-format branch April 7, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants