[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set template default node.js version to 10 because support of node.js8 will end #2407

Merged

Conversation

tadashi0713
Copy link
Contributor

Description

Set template default node.js version to 10 because support of node.js8 will end

スクリーンショット 2020-06-28 16 15 34

Scenarios Tested

Sample Commands

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Manual indication that this has passed CLA. and removed cla: no labels Jun 28, 2020
@samtstern
Copy link
Contributor

@tadashi0713 thanks for this! As you can see @mbleigh already did most of the work here (#2396) but you're right we missed a few spots.

@samtstern samtstern merged commit adfb601 into firebase:master Jun 29, 2020
@tadashi0713 tadashi0713 deleted the set-functions-template-nodejs-10 branch June 30, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants