Add e2e tests for the Auth emulator #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
approved these changes
Oct 28, 2020
bkendall
reviewed
Oct 28, 2020
| #!/usr/bin/env bash | ||
| set -e | ||
|
|
||
| if [ "$CI" = "true" ]; then |
There was a problem hiding this comment.
If you don't care what CI is set to (just that it isn't empty), you could use -z:
if [ ! -z "$CI" ]; then
bkendall
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #2727
To properly test this we need Admin SDK 9+ which means Node 10+ which means I had to do some funky business.
Scenarios Tested
The whole PR is tests
Sample Commands
N/A