remove request module from database helpers #2828
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
request
is deprecated. replacing usages of it with the newapiv2
client.I also found some interesting cases where
databse:get
wouldn't write to the output file correctly, so I re-vamped the logic to make sure that the command only exits when the streams fully complete.I also added some client-integration tests for the
database:*
commands, which helped debug & fix.Scenarios Tested
database:get
database:set
database:remove
Sample Commands