move emulator suite tests into scripts folder #3035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, the coverage went down, but there's not much I can do about that at the moment. New, more unity tests would have to be written for some of the emulator parts. |
samtstern
approved these changes
Jan 15, 2021
scripts/emulator-tests/run.sh
Outdated
|
|
||
| # Run the tests from the built dev directory. | ||
| mocha \ | ||
| --bail \ |
There was a problem hiding this comment.
Generally we don't use --bail (although I don't mind), did you intend to do this?
scripts/emulator-tests/run.sh
Outdated
| dev/scripts/emulator-tests/*.spec.* | ||
|
|
||
| # Remove the built artifacts. | ||
| rm -rf dev |
There was a problem hiding this comment.
Will this run if mocha fails?
There was a problem hiding this comment.
I replaced it with a trap so it will always be run on exit :)
…s into bk-emulator-suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These tests aren't really "unit" tests as much as they are "integration" or "functional" tests. They take ~500ms each to run, so taking them out of our "unit" test path would speed them up greatly (down to 9s, in fact).
This does a little bit of fancy footwork. The process for these particular tests is this:
devdirectorydev/scriptsusing mochadevIt's a little odd, but it allows the fact that it spawns child processes using node and the generated code, making it a bit easier.
The reason I don't want to do this with all the unit tests (even though these tests still take ~10s, which doubles the unit tests runtime) is that I lose the source mappings and coverage information. For some reason, these tests fail in strange ways when I generate the source maps alongside the code (which is why they're disabled).