[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect TimeZone in scheduled functions #3434

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Respect TimeZone in scheduled functions #3434

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
712f7d4
Copy TimeZone from spec to Job
inlined Jun 1, 2021
ecff528
Add regression test
inlined Jun 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Copy TimeZone from spec to Job
  • Loading branch information
@inlined
inlined committed Jun 1, 2021
commit 712f7d48b84e00ae01456a29139f426d60ba7320
2 changes: 1 addition & 1 deletion src/deploy/functions/backend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ export function toJob(schedule: ScheduleSpec, appEngineLocation: string): clouds
name: scheduleName(schedule, appEngineLocation),
schedule: schedule.schedule!,
};
proto.copyIfPresent(job, schedule, "retryConfig");
proto.copyIfPresent(job, schedule, "timeZone", "retryConfig");
if (schedule.transport === "https") {
throw new FirebaseError("HTTPS transport for scheduled functions is not yet supported");
}
Expand Down