[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require firebase-functions >= 3.13.1 in functions emulator. #3851

Merged
merged 3 commits into from
Dec 14, 2021
+2 −1
Merged

Require firebase-functions >= 3.13.1 in functions emulator. #3851

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b5fbc2
Require firebase-functions >= 3.13.1 in functions emulator.
yuchenshi Oct 21, 2021
b05bf7e
Update CHANGELOG.md
yuchenshi Oct 21, 2021
76e3e6d
Merge branch 'next' into yuchenshi-patch-1
bkendall Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Require firebase-functions >= 3.13.1 in functions emulator. 
To include the fix in firebase/firebase-functions#838, causing a hard to debug issue when both database and functions emulators are started.
  • Loading branch information
@yuchenshi
yuchenshi committed Oct 21, 2021
commit 4b5fbc21d0bbfccfbaf5b384c7a89084047cc573
2 changes: 1 addition & 1 deletion src/emulator/functionsEmulatorRuntime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ async function assertResolveDeveloperNodeModule(
async function verifyDeveloperNodeModules(frb: FunctionsRuntimeBundle): Promise<boolean> {
const modBundles = [
{ name: "firebase-admin", isDev: false, minVersion: "8.9.0" },
{ name: "firebase-functions", isDev: false, minVersion: "3.3.0" },
{ name: "firebase-functions", isDev: false, minVersion: "3.13.1" },
];

for (const modBundle of modBundles) {
Expand Down