[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add better messaging when the emulator UI isn't started #4658

Merged
merged 7 commits into from
Jun 22, 2022
Merged

Conversation

bkendall
Copy link
Contributor
@bkendall bkendall commented Jun 16, 2022

Description

Adds better messaging when the emulator UI isn't started.

Fixes #3781

src/emulator/controller.ts Outdated Show resolved Hide resolved
src/emulator/controller.ts Outdated Show resolved Hide resolved
@bkendall bkendall enabled auto-merge (squash) June 22, 2022 16:06
@bkendall bkendall dismissed rachelsaunders’s stale review June 22, 2022 16:32

chatted offline, made changes as requested.

@bkendall bkendall merged commit 004429b into master Jun 22, 2022
@bkendall bkendall deleted the bk3781 branch June 22, 2022 16:32
Copy link
Contributor
@rachelsaunders rachelsaunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firebase emulators:start --only hosting does not start emulator-ui
3 participants