Fix "bug" where function timeout option did not apply to Functions Emulator. #4745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4745 +/- ##
=======================================
Coverage 57.66% 57.66%
=======================================
Files 287 287
Lines 18546 18548 +2
Branches 3628 3629 +1
=======================================
+ Hits 10694 10696 +2
- Misses 6978 6979 +1
+ Partials 874 873 -1
Continue to review full report at Codecov.
|
colerogers
approved these changes
Jul 18, 2022
|
When I use cli v11.* (11.4.0) my functions not work Error("Function timed out."). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several months ago, we started to refactor the Functions Emulator with the goal of the Emulator implement more closely resembling how GCF works.
One way the Emulator and GCF differed was how timeout was enforced - in GCF that work was done outside of the runtime process whereas in the emulated environment it was enforced by the runtime process itself.
Our work on redesigning the emulator still has much more work to do. It was premature of me to remove a well working feature - again, hubris got the best of me ("I'll add the feature back in just a week or two!".
Many users have spoken out - so I'm proposing here we bring back the timeout feature I ripped out few months ago. It'll be our responsibility to preserve this feature in the redesign-ed the Emulator.
Fixes #2837