[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix functions emulator #6968

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Fix functions emulator #6968

merged 2 commits into from
Apr 5, 2024

Conversation

inlined
Copy link
Member
@inlined inlined commented Apr 5, 2024

A fallback runtime is completely unnecessary given our ability to dynamically detect it. In fact, it breaks dynamic detection!

Fixes #6965

@inlined inlined requested a review from joehan April 5, 2024 16:20
Copy link
Contributor
@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after you npm run format

@joehan joehan enabled auto-merge (squash) April 5, 2024 17:46
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 54.80%. Comparing base (97c5a8e) to head (54fd7b7).

Files Patch % Lines
src/emulator/controller.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6968   +/-   ##
=======================================
  Coverage   54.79%   54.80%           
=======================================
  Files         359      359           
  Lines       25111    25109    -2     
  Branches     5176     5175    -1     
=======================================
  Hits        13760    13760           
+ Misses      10113    10111    -2     
  Partials     1238     1238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joehan joehan merged commit 8e9929f into master Apr 5, 2024
35 checks passed
@inlined inlined deleted the inlined.fix-functions-emulator branch April 7, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 13.7.0 now requires manually adding "runtime" configuration in firebase.json
3 participants