"Connect to Postgres" using ConfigureEmulator API #7262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Add UI for Connect to Postgres, and displaying postgres connection after
- Local endpoint is a class function in EmulatorController
- Implement DataConnectEmulatorClient, and ConfigureEmulator api
yuchenshi
reviewed
Jun 4, 2024
| } | ||
|
|
||
| return ( | ||
| "http://" + dataConnectEmulator.host + ":" + dataConnectEmulator.port |
There was a problem hiding this comment.
Please handle IPv6 quoting similar to
firebase-tools/src/emulator/registry.ts
Lines 180 to 181 in 1633d69
yuchenshi
approved these changes
Jun 4, 2024
joehan
requested changes
Jun 4, 2024
joehan
reviewed
Jun 4, 2024
* Autoconnect to postgres when not in VSCE * Format * Return values
|
Merged my PR onto yours to autoconnect when not in vscode |
joehan
approved these changes
Jun 4, 2024
| }); | ||
|
|
||
| return connectionString; | ||
| } | ||
|
|
||
| private async connectToPostgres() { | ||
| const rc = firebaseRC.value?.tryReadValue; | ||
| const newConnectionString = await this.promptConnectionString( | ||
| rc?.getDataconnect()?.postgres.localConnectionString || | ||
| "postgres://user:password@localhost:5432/dbname", |
There was a problem hiding this comment.
Should we use switch the default string to point to the 'postgres' DB?
Suggested change
| "postgres://user:password@localhost:5432/dbname", | |
| "postgres://user:password@localhost:5432/postgres", |
src/emulator/dataconnectEmulator.ts
Outdated
| @@ -2,13 +2,17 @@ import * as childProcess from "child_process"; | |||
|
|
|||
| import { dataConnectLocalConnString } from "../api"; | |||
| import { Constants } from "./constants"; | |||
| import { getPID, start, stop, downloadIfNecessary } from "./downloadableEmulators"; | |||
| import { getPID, start, stop, downloadIfNecessary | |||
There was a problem hiding this comment.
Looks like we just need to run 'npm run format'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.