[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Auth examples with GoogleSignIn 6.0.0 #1222

Merged
merged 5 commits into from
Jul 14, 2021
Merged

Update Auth examples with GoogleSignIn 6.0.0 #1222

merged 5 commits into from
Jul 14, 2021

Conversation

maksymmalyhin
Copy link
Contributor

Fixes #1218.

@google-cla google-cla bot added the cla: yes label Jul 14, 2021
@maksymmalyhin maksymmalyhin changed the base branch from dpebot-repositorygardener to master July 14, 2021 14:19
@paulb777
Copy link
Member

This is strange - https://github.com/firebase/quickstart-ios/blob/master/.github/workflows/authentication.yml#L12

@maksymmalyhin
Copy link
Contributor Author

This is strange - https://github.com/firebase/quickstart-ios/blob/master/.github/workflows/authentication.yml#L12

Yeah, it seems the branch restriction should be removed for pull requests. @morganchen12 Is there any particular reason it was added there?

maksymmalyhin
maksymmalyhin commented Jul 14, 2021
View reviewed changes
authentication/LegacyAuthQuickstart/AuthenticationExample/AppDelegate.m
@@ -35,11 +35,6 @@ - (BOOL)application:(UIApplication *)application
[FIRApp configure];
// [END firebase_configure]

// [START setup_gidsignin]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morganchen12 I'm not sure if the tags are affecting anything and if I updated them properly. Could you PTAL.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting this snippet is ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG. Please add me to reviewers for the updated docs to ensure they have correct snippets.

paulb777
paulb777 reviewed Jul 14, 2021
View reviewed changes
Copy link
Member
@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Maksym! LGTM

Deferring review of doc tags and approval to @morganchen12

morganchen12
morganchen12 approved these changes Jul 14, 2021
View reviewed changes
authentication/LegacyAuthQuickstart/AuthenticationExample/AppDelegate.m
@@ -35,11 +35,6 @@ - (BOOL)application:(UIApplication *)application
[FIRApp configure];
// [END firebase_configure]

// [START setup_gidsignin]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting this snippet is ok.

@maksymmalyhin maksymmalyhin merged commit edb4c18 into master Jul 14, 2021
@maksymmalyhin maksymmalyhin deleted the mm/google-signin-update branch July 14, 2021 17:58
@paulb777 paulb777 mentioned this pull request Jul 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 left review comments

@morganchen12 morganchen12 morganchen12 approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Authentication example should be updated for GoogleSignIn 6.0.0
4 participants
@maksymmalyhin @paulb777 @morganchen12 @dpebot