Add POC for RUTv2 with JS v9 modular SDK. #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markarndt
approved these changes
Sep 1, 2021
|
The failing tests in firestore.spec.js and database.spec.js are blocking the update to v9. I'll make sure that any tests there are recreated in the new tests, and then replace those files with these. |
yuchenshi
commented
Sep 14, 2021
|
Merged, but note that tests for v9 directory won't pass until firebase/firebase-js-sdk#5501 is fixed. I'll enable CI for the directory after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some minimal tests (assertsFail and assertSucceed, authed and unauthed, RTDB and Firestore) to show the format of the new Rules Unit Testing library (RUT). This PR also functions as a summary of the changes necessary to start testing in an existing project.
Happy testing!
馃尮馃崚馃崜馃尪馃帓馃巿馃崕 馃И馃崁 馃挌 馃 馃嵉 馃尩馃崗