[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Node.js Auth Token Claims #35

Merged
merged 3 commits into from
Mar 21, 2019
Merged

Adding Node.js Auth Token Claims #35

merged 3 commits into from
Mar 21, 2019

Conversation

jenperson
Copy link
Contributor

@samtstern
Copy link
Contributor

Snippets mostly look good but Travis is unhappy:

/home/travis/build/firebase/snippets-node/auth/create_custom_tokens.js
   3:1   error  'admin' is not defined        no-undef
   8:1   error  'admin' is not defined        no-undef
  14:11  error  Strings must use singlequote  quotes
  16:1   error  'admin' is not defined        no-undef
  21:17  error  Strings must use singlequote  quotes
  26:5   error  'uid' is already defined      no-redeclare
  26:11  error  Strings must use singlequote  quotes
  31:1   error  'admin' is not defined        no-undef
  36:17  error  Strings must use singlequote  quotes

@samtstern
Copy link
Contributor

I think all you need is to import the Admin SDK at the top and then fix the quotes to all be ' not "

@jenperson
Removing double quotes, adding admin import
6c30959 
Removing any double quotes and adding an admin
import statement to the top of the file to resolve
Travis CI build failure.
@jenperson
Adding firestore timestamp setting
f88af1a 
Adding Cloud Firestore timestamp setting to Admin Firestore app
as lint requests
@samtstern
Copy link
Contributor

@jenperson Travis is wrong, not you.

@samtstern samtstern merged commit 733e6ed into master Mar 21, 2019
@jenperson
Copy link
Contributor Author

Alrighty. I think it's going to complain about those Firestore snippets whenever I do a PR though

@jenperson jenperson deleted the add-snippets branch March 21, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samtstern samtstern Awaiting requested review from samtstern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jenperson @samtstern