[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use_super_parameters lint #861

Merged
merged 59 commits into from
May 20, 2022
Merged

Add use_super_parameters lint #861

merged 59 commits into from
May 20, 2022

Conversation

domesticmouse
Copy link
Contributor

Review after #859 has landed

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@domesticmouse
Copy link
Contributor Author

Adding @khanhnwin and @jfschmakeit for changes to Photos and Boring to Beautiful codelabs

@domesticmouse domesticmouse merged commit cc00a77 into flutter:main May 20, 2022
@domesticmouse domesticmouse deleted the super-parameter-update branch May 20, 2022 17:23
@codecypher
Copy link

Well, line 23 needs to be replaced with the following:

  const MyApp({key}) : super(key: key);

@domesticmouse
Copy link
Contributor Author

Well, line 23 needs to be replaced with the following:

  const MyApp({key}) : super(key: key);

Line 23 of which file?

codecypher added a commit to codecypher/codelabs that referenced this pull request Jul 28, 2022
This fixed the compiler errors for me so that I was able to run the google_maps_in_flutter sample code (dart 2.15.1 and flutter 2.8.1-stable) related to "Add use_super_parameters lint flutter#861"
@codecypher
Copy link

Please take a look at my PR. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants