-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add use_super_parameters
lint
#861
Merged
domesticmouse
merged 59 commits into
flutter:main
from
domesticmouse:super-parameter-update
May 20, 2022
Merged
Add use_super_parameters
lint
#861
domesticmouse
merged 59 commits into
flutter:main
from
domesticmouse:super-parameter-update
May 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tter-pub-upgrade
…ptive_app-codelab_rebuild-update
…e/codelabs into adaptive_app-codelab_rebuild-update
…com/domesticmouse/codelabs into cupertino_store-codelab_rebuild-update
…ub.com/domesticmouse/codelabs into firebase-get-to-know-flutter-codelab_rebuild-update
…ttps://github.com/domesticmouse/codelabs into github-client-codelab_rebuild-update
…ub.com/domesticmouse/codelabs into firebase-get-to-know-flutter-codelab_rebuild-update
…ttps://github.com/domesticmouse/codelabs into github-client-codelab_rebuild-update
….com/domesticmouse/codelabs into super-parameter-update
…ttps://github.com/domesticmouse/codelabs into github-client-codelab_rebuild-update
….com/domesticmouse/codelabs into super-parameter-update
….com/domesticmouse/codelabs into super-parameter-update
…ptive_app-codelab_rebuild-update
…com/domesticmouse/codelabs into cupertino_store-codelab_rebuild-update
…ub.com/domesticmouse/codelabs into firebase-get-to-know-flutter-codelab_rebuild-update
…ttps://github.com/domesticmouse/codelabs into github-client-codelab_rebuild-update
….com/domesticmouse/codelabs into super-parameter-update
…er-parameter-update
Adding @khanhnwin and @jfschmakeit for changes to Photos and Boring to Beautiful codelabs |
khanhnwin
approved these changes
May 20, 2022
Well, line 23 needs to be replaced with the following: const MyApp({key}) : super(key: key); |
Line 23 of which file? |
codecypher
added a commit
to codecypher/codelabs
that referenced
this pull request
Jul 28, 2022
This fixed the compiler errors for me so that I was able to run the google_maps_in_flutter sample code (dart 2.15.1 and flutter 2.8.1-stable) related to "Add use_super_parameters lint flutter#861"
4 tasks
Please take a look at my PR. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review after #859 has landed
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.