[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for breaking changes in IAP plugin #123

Merged
merged 6 commits into from
May 13, 2021
Merged

Update for breaking changes in IAP plugin #123

merged 6 commits into from
May 13, 2021

Conversation

renefloor
Copy link
Contributor

The in_app_purchases package will have some breaking changes soon. This PR adapts the codelab example for the coming breaking changes in flutter/plugins/pull/3877

@renefloor
Update iap example app with breakign changes
138e642
@renefloor
Renamed IAP sources
df9fcbe 
GooglePlay becomes google_play and AppStore becomes app_store
@google-cla google-cla bot added the cla: yes label May 12, 2021
domesticmouse
domesticmouse requested changes May 12, 2021
View reviewed changes
Copy link
Contributor
@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing you are waiting on an updated package to be published before we land this PR?

in_app_purchases/complete/app/pubspec.lock Outdated Show resolved Hide resolved
in_app_purchases/complete/app/pubspec.yaml Outdated Show resolved Hide resolved
in_app_purchases/step_06/app/pubspec.lock Outdated Show resolved Hide resolved
in_app_purchases/step_06/app/pubspec.yaml Outdated Show resolved Hide resolved
in_app_purchases/step_07/app/pubspec.yaml Outdated Show resolved Hide resolved
in_app_purchases/step_08/app/pubspec.yaml Outdated Show resolved Hide resolved
in_app_purchases/step_09/app/pubspec.yaml Outdated Show resolved Hide resolved
@renefloor
Copy link
Contributor Author
renefloor commented May 12, 2021 •
edited
Loading

I'm guessing you are waiting on an updated package to be published before we land this PR?

Yep, the PR mentioned in the PR post needs to be released: flutter/plugins/pull/3877
The platform interface is already published, the android, iOS implementations and the app facing package not yet.

@domesticmouse
Copy link
Contributor

I'd suggest marking this PR as WIP until the packages are published.

@renefloor renefloor changed the title Update for breaking changes in IAP plugin [WIP] Update for breaking changes in IAP plugin May 12, 2021
@domesticmouse domesticmouse self-assigned this May 13, 2021
@renefloor renefloor changed the title [WIP] Update for breaking changes in IAP plugin Update for breaking changes in IAP plugin May 13, 2021
@renefloor renefloor marked this pull request as ready for review May 13, 2021 15:38
@domesticmouse domesticmouse merged commit 513a305 into flutter:master May 13, 2021
@mvanbeusekom mvanbeusekom deleted the iap-update branch October 18, 2021 12:48
@kleeb
Copy link
kleeb commented May 23, 2022

any plans for making those samples working ?

src/iap.repository.ts:1:9 - error TS2724: '"firebase-admin/lib/firestore"' has no exported member named 'firestore'. Did you mean 'Firestore'?

import {firestore} from "firebase-admin/lib/firestore";

@domesticmouse
Copy link
Contributor

any plans for making those samples working ?

src/iap.repository.ts:1:9 - error TS2724: '"firebase-admin/lib/firestore"' has no exported member named 'firestore'. Did you mean 'Firestore'?

import {firestore} from "firebase-admin/lib/firestore";

I'm part way through rebuilding the codelab to use a Dart back end running on Cloud Run, which is more suitable for us to maintain going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

Assignees

@domesticmouse domesticmouse

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renefloor @domesticmouse @kleeb