[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate in-app-purchases to Material 3 #1349

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Migrate in-app-purchases to Material 3 #1349

merged 2 commits into from
Jan 30, 2023

Conversation

miquelbeltran
Copy link
Member
@miquelbeltran miquelbeltran commented Jan 17, 2023 •
edited
Loading

Enabled Material 3 on the in-app-purchases codelab.

Replaced an ElevatedButton with a FilledButton on the Login screen.

Before Material 3

With Material 3

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@miquelbeltran miquelbeltran marked this pull request as ready for review January 18, 2023 13:19
@miquelbeltran
Copy link
Member Author

@domesticmouse is it OK to merge even if it does not compile on Stable? or should I hold until next release?

@domesticmouse
Copy link
Contributor

@domesticmouse is it OK to merge even if it does not compile on Stable? or should I hold until next release?

Hold until stable increments. I could add this to the beta update PR if you want me to land this change.

@miquelbeltran miquelbeltran changed the base branch from main to beta January 19, 2023 13:11
@miquelbeltran
Copy link
Member Author

I changed the base branch to beta.

In any case, we can decide tomorrow in the call.

Base automatically changed from beta to main January 24, 2023 23:14
@miquelbeltran
Copy link
Member Author

Waiting for CI to finish and go green, then I'll merge.

@miquelbeltran miquelbeltran merged commit d43fcec into main Jan 30, 2023
@miquelbeltran miquelbeltran deleted the mb-in_app_purchases-material-3 branch January 30, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miquelbeltran @domesticmouse