[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline IAP code with documentation updates #253

Merged
merged 10 commits into from
Jan 6, 2022
Merged

Streamline IAP code with documentation updates #253

merged 10 commits into from
Jan 6, 2022

Conversation

jopmiddelkamp
Copy link
Contributor

Upped the IAP step folders as I've added a new section to the codelab documentation.

Before:
Screenshot 2021-12-14 at 13 52 38

After:
Screenshot 2021-12-14 at 13 51 30

Related issue:

flutter/flutter#90991

Pre-launch Checklist:

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@domesticmouse
Copy link
Contributor

You'll want to pull from master as this PR is significantly behind. Also, have you re-created the Flutter Runners for v2.8.0? I started down that path, but it isn't yet in a sane state.

@domesticmouse
Copy link
Contributor

@jopmiddelkamp I've staged the updated codelab. Let me know when you are ready for me to land this PR and the matching codelab update.

@jopmiddelkamp
Copy link
Contributor Author

@domesticmouse This morning I've also updated the analysis options of all steps so it requires another review. Besides that, I've also updated the code lab document to match the changes. So if you don't find anything strange in my last commit we are ready to deploy the latest version of the codelab document and this PR.

domesticmouse
domesticmouse requested changes Jan 4, 2022
View reviewed changes
Copy link
Contributor
@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to centralise analysis configuration. Please update all analysis_options.yaml files to point at https://github.com/flutter/codelabs/blob/master/analysis_options.yaml

in_app_purchases/complete/app/analysis_options.yaml Outdated Show resolved Hide resolved
in_app_purchases/step_00/app/analysis_options.yaml Outdated Show resolved Hide resolved
in_app_purchases/step_07/app/analysis_options.yaml Outdated Show resolved Hide resolved
in_app_purchases/step_08/app/analysis_options.yaml Outdated Show resolved Hide resolved
in_app_purchases/step_09/app/analysis_options.yaml Outdated Show resolved Hide resolved
in_app_purchases/step_10/app/analysis_options.yaml Outdated Show resolved Hide resolved
domesticmouse
domesticmouse approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor
@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll land this at the same time as the updated codelab text

@domesticmouse
Copy link
Contributor

One blocker, one nit:

  • In the codelab text, there is a non-english screenshot. Please replace with an english language screenshot.
  • The firebase_core dependency is 1.0.3 while the latest published is 1.10.6. Update dependencies?

@jopmiddelkamp
Copy link
Contributor Author

One blocker, one nit:

  • In the codelab text, there is a non-english screenshot. Please replace with an english language screenshot.
  • The firebase_core dependency is 1.0.3 while the latest published is 1.10.6. Update dependencies?

Fixed both issues.

@domesticmouse domesticmouse merged commit 5870090 into flutter:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

@mvanbeusekom mvanbeusekom Awaiting requested review from mvanbeusekom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jopmiddelkamp @domesticmouse