[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also maintain the zone on the ChannelBuffers.push callback #22454

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Also maintain the zone on the ChannelBuffers.push callback #22454

merged 1 commit into from
Nov 17, 2020

Conversation

Hixie
Copy link
Contributor
@Hixie Hixie commented Nov 11, 2020

When I did the ChannelBuffers refactor I missed that the callback also might be in a different zone, and we should maintain that also.

@google-cla google-cla bot added the cla: yes label Nov 11, 2020
@Hixie Hixie force-pushed the channel_buffers_2 branch 2 times, most recently from 3edc4bf to 4de4daa Compare November 13, 2020 07:55
liyuqian
liyuqian approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor
@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie Hixie added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 17, 2020
@fluttergithubbot fluttergithubbot merged commit 1a5ec52 into flutter:master Nov 17, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 17, 2020
@engine-flutter-autoroll
1a5ec52 Also maintain the zone on the ChannelBuffers.push callback (f…
0a72603 
…lutter/engine#22454)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 17, 2020
@engine-flutter-autoroll
1a5ec52 Also maintain the zone on the ChannelBuffers.push callback (f…
0369204 
…lutter/engine#22454)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 17, 2020
@engine-flutter-autoroll
1a5ec52 Also maintain the zone on the ChannelBuffers.push callback (f…
5fb84a7 
…lutter/engine#22454)
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
@Hixie @chaselatta
Also maintain the zone on the ChannelBuffers.push callback (flutter#2…
6379737 
…2454)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyuqian liyuqian liyuqian approved these changes

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
3 participants
@Hixie @liyuqian @fluttergithubbot