[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK constraints are now just generally required #23493

Merged
merged 1 commit into from
Jan 9, 2021
Merged

SDK constraints are now just generally required #23493

merged 1 commit into from
Jan 9, 2021

Conversation

Hixie
Copy link
Contributor
@Hixie Hixie commented Jan 7, 2021

...so this comment is obsolete.

(Part of a wider audit of various pubspec.yamls I'm doing.)

@Hixie
SDK constraints are now just generally required
2d08b76 
...so this comment is obsolete.
@google-cla google-cla bot added the cla: yes label Jan 7, 2021
@Hixie
Copy link
Contributor Author
Hixie commented Jan 7, 2021

cc @dnfield

dnfield
dnfield approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor
@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 7, 2021
@chinmaygarde
Copy link
Member

I've filed a flake report and re-run the presubmit.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 8, 2021
@Hixie Hixie added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 9, 2021
@fluttergithubbot fluttergithubbot merged commit 3eaa344 into flutter:master Jan 9, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 11, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 11, 2021
@engine-flutter-autoroll
3eaa344 SDK constraints are now just generally required (flutter/engi…
57ce0a2 
…ne#23493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnfield dnfield dnfield approved these changes

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
4 participants
@Hixie @chinmaygarde @fluttergithubbot @dnfield