[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the images for TileMode.decal #26482

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Add the images for TileMode.decal #26482

merged 1 commit into from
Jun 2, 2021

Conversation

Hixie
Copy link
Contributor
@Hixie Hixie commented May 28, 2021

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label May 28, 2021
@Hixie Hixie requested a review from flar May 28, 2021 21:38
@Hixie
Copy link
Contributor Author
Hixie commented May 28, 2021

See #22982 (comment)

flar
flar approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor
@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie Hixie added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 2, 2021
@fluttergithubbot fluttergithubbot merged commit c7cd83b into flutter:master Jun 2, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 3, 2021
@engine-flutter-autoroll
c7cd83b Add the images for TileMode.decal (flutter/engine#26482)
90b250c
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@Hixie
Add the images for TileMode.decal (flutter#26482)
9998453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flar flar flar approved these changes

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
3 participants
@Hixie @flar @fluttergithubbot