[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: add support for TextInputType.none #26585

Merged
merged 8 commits into from
Jun 29, 2021
Merged

Android: add support for TextInputType.none #26585

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f5d9376
Android: add support for TextInputType.none
jpnurmi Jun 3, 2021
bf325ba
No input connection for TextInputType.none
jpnurmi Jun 16, 2021
876274d
Fix TextInputPluginTest
jpnurmi Jun 16, 2021
7220e97
Fix setTextInputClient() & add test
jpnurmi Jun 22, 2021
9afec70
Cleanup inputConnection_textInputTypeNone()
jpnurmi Jun 22, 2021
5df062a
Test that TextInputType.NONE is actually honored
jpnurmi Jun 22, 2021
fc89854
Merge remote-tracking branch 'upstream/master' into android-text-inpu…
jpnurmi Jun 24, 2021
0dbfa4e
Adapt to API change
jpnurmi Jun 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test that TextInputType.NONE is actually honored
  • Loading branch information
@jpnurmi
jpnurmi committed Jun 22, 2021
commit 5df062aea9057ecae06f596bbb76b0997c592e2d
3 changes: 2 additions & 1 deletion shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,8 @@ private boolean canShowTextInput() {
return configuration.inputType.type != TextInputChannel.TextInputType.NONE;
}

private void showTextInput(View view) {
@VisibleForTesting
void showTextInput(View view) {
if (canShowTextInput()) {
view.requestFocus();
mImm.showSoftInput(view, 0);
Expand Down
27 changes: 27 additions & 0 deletions shell/platform/android/test/io/flutter/plugin/editing/TextInputPluginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,6 +620,33 @@ public void inputConnection_textInputTypeNone() {
assertEquals(connection, null);
}

@Test
public void showTextInput_textInputTypeNone() {
TestImm testImm =
Shadow.extract(
RuntimeEnvironment.application.getSystemService(Context.INPUT_METHOD_SERVICE));
View testView = new View(RuntimeEnvironment.application);
DartExecutor dartExecutor = mock(DartExecutor.class);
TextInputChannel textInputChannel = new TextInputChannel(dartExecutor);
TextInputPlugin textInputPlugin =
new TextInputPlugin(testView, textInputChannel, mock(PlatformViewsController.class));
textInputPlugin.setTextInputClient(
0,
new TextInputChannel.Configuration(
false,
false,
true,
TextInputChannel.TextCapitalization.NONE,
new TextInputChannel.InputType(TextInputChannel.TextInputType.NONE, false, false),
null,
null,
null,
null));

textInputPlugin.showTextInput(testView);
assertEquals(testImm.isSoftInputVisible(), false);
}

// -------- Start: Autofill Tests -------
@Test
public void autofill_onProvideVirtualViewStructure() {
Expand Down