Adds python3_action GN target #27211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chaselatta - You asked me to break out this change and move it outside of the |
chaselatta
approved these changes
Jul 7, 2021
e99900d
to
49979fe
Compare
|
This needs to be rebased for the presubmits to pass. |
49979fe
to
6c0e7e1
Compare
Ah, now I understand the (That error message is very cryptic!) |
Ninja runs `action` scripts using the default python interpretter, and most flutter build scripts that use python currently require python2. In order to support python3 scripts as well, the `python3_action` invokes a wrapper python2-based script via GN `action` target, and the wrapper invokes the python3 interpretter with the given script. This new target is required to support flutter#26880, but is broken out to a separate PR (by request) to support other more immediate use cases.
6c0e7e1
to
c045973
Compare
|
@chinmaygarde - This finally passes. OK to merge? |
|
Go for it! |
|
Thanks. I don't have merge privs, and Chase is OOO. Can you help? |
|
Thank you @jason-simmons ! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 16, 2021
moffatman
pushed a commit
to moffatman/engine
that referenced
this pull request
Aug 5, 2021
Ninja runs `action` scripts using the default python interpretter, and most flutter build scripts that use python currently require python2. In order to support python3 scripts as well, the `python3_action` invokes a wrapper python2-based script via GN `action` target, and the wrapper invokes the python3 interpretter with the given script. This new target is required to support flutter#26880, but is broken out to a separate PR (by request) to support other more immediate use cases.
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
Ninja runs `action` scripts using the default python interpretter, and most flutter build scripts that use python currently require python2. In order to support python3 scripts as well, the `python3_action` invokes a wrapper python2-based script via GN `action` target, and the wrapper invokes the python3 interpretter with the given script. This new target is required to support flutter#26880, but is broken out to a separate PR (by request) to support other more immediate use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ninja runs
actionscripts using the default python interpretter, andmost flutter build scripts that use python currently require python2. In
order to support python3 scripts as well, the
python3_actioninvokes awrapper python2-based script via GN
actiontarget, and the wrapperinvokes the python3 interpretter with the given script.
This new target is required to support #26880, but is
broken out to a separate PR (by request) to support other more immediate
use cases.
List which issues are fixed by this PR. You must list at least one issue.
Regarding flutter/flutter#53002: Note that this is a temporary workaround for python3 scripts, while python2 is still required. Once python3 is the default, the
python3_actiontargets can be changed to simplyaction, and the files in this PR will no longer be needed.Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.