-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds python3_action GN target #27211
Conversation
@chaselatta - You asked me to break out this change and move it outside of the |
e99900d
to
49979fe
Compare
This needs to be rebased for the presubmits to pass. |
49979fe
to
6c0e7e1
Compare
Ah, now I understand the (That error message is very cryptic!) |
Ninja runs `action` scripts using the default python interpretter, and most flutter build scripts that use python currently require python2. In order to support python3 scripts as well, the `python3_action` invokes a wrapper python2-based script via GN `action` target, and the wrapper invokes the python3 interpretter with the given script. This new target is required to support flutter#26880, but is broken out to a separate PR (by request) to support other more immediate use cases.
6c0e7e1
to
c045973
Compare
@chinmaygarde - This finally passes. OK to merge? |
Go for it! |
Thanks. I don't have merge privs, and Chase is OOO. Can you help? |
Thank you @jason-simmons ! |
Ninja runs `action` scripts using the default python interpretter, and most flutter build scripts that use python currently require python2. In order to support python3 scripts as well, the `python3_action` invokes a wrapper python2-based script via GN `action` target, and the wrapper invokes the python3 interpretter with the given script. This new target is required to support flutter#26880, but is broken out to a separate PR (by request) to support other more immediate use cases.
Ninja runs `action` scripts using the default python interpretter, and most flutter build scripts that use python currently require python2. In order to support python3 scripts as well, the `python3_action` invokes a wrapper python2-based script via GN `action` target, and the wrapper invokes the python3 interpretter with the given script. This new target is required to support flutter#26880, but is broken out to a separate PR (by request) to support other more immediate use cases.
Ninja runs
action
scripts using the default python interpretter, andmost flutter build scripts that use python currently require python2. In
order to support python3 scripts as well, the
python3_action
invokes awrapper python2-based script via GN
action
target, and the wrapperinvokes the python3 interpretter with the given script.
This new target is required to support #26880, but is
broken out to a separate PR (by request) to support other more immediate
use cases.
List which issues are fixed by this PR. You must list at least one issue.
Regarding flutter/flutter#53002: Note that this is a temporary workaround for python3 scripts, while python2 is still required. Once python3 is the default, the
python3_action
targets can be changed to simplyaction
, and the files in this PR will no longer be needed.Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.