[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused python_binary build artifacts #28111

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Remove unused python_binary build artifacts #28111

merged 1 commit into from
Aug 16, 2021

Conversation

richkadel
Copy link
Contributor

Removes python_binary completely, now that it is unused, in lieu of
the push to migrate python scripts to vpython3.

I confirmed a clean build in PR #26880 still works with these changes.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@richkadel
Remove unused python_binary build artifacts
792ca18 
removes `python_binary` completely, now that it is unused, in lieu of
the push to migrate python scripts to `vpython3`.
@google-cla google-cla bot added the cla: yes label Aug 16, 2021
@richkadel
Copy link
Contributor Author

@iskakaushik

iskakaushik
iskakaushik approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor
@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richkadel
Copy link
Contributor Author

Infra Failure: Step('gcloud pubsub') (retcode: 1)

@iskakaushik
Copy link
Contributor

@richkadel i reran it, looks like its a flake.

@iskakaushik iskakaushik added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 16, 2021
@fluttergithubbot fluttergithubbot merged commit ae0401d into flutter:master Aug 16, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 16, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2021
@engine-flutter-autoroll
ae0401d Remove unused python_binary build artifacts (flutter/engine#2…
39ab926 
…8111)
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
@richkadel @filmil
Remove unused python_binary build artifacts (flutter#28111)
f343d5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iskakaushik iskakaushik iskakaushik approved these changes

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
3 participants
@richkadel @iskakaushik @fluttergithubbot