Fix some clang-tidy lints for Linux host_debug #29734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Nov 15, 2021
shell/common/shell_unittests.cc
Outdated
| @@ -1877,7 +1877,7 @@ TEST_F(ShellTest, CanConvertToAndFromMappings) { | |||
| const size_t buffer_size = 2 << 20; | |||
|
|
|||
| uint8_t* buffer = static_cast<uint8_t*>(::malloc(buffer_size)); | |||
| ASSERT_NE(buffer, nullptr); | |||
| ASSERT_NE(buffer, nullptr); // NOLINT(clang-analyzer-unix.Malloc) | |||
There was a problem hiding this comment.
I think assert_true would avoid the ignore
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to main. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
|
@CaseyHillers Why is this PR still blocked? |
|
This one also mysteriously flipped back to |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some curly braces, some instances of
explicit, and converts some C style casts to C++ style casts.For flutter/flutter#93576