Treat clang-analyzer-osx warnings as errors #29755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Nov 15, 2021
| @@ -1 +1,2 @@ | |||
| Checks: 'google-*' | |||
| WarningsAsErrors: 'clang-analyzer-osx.*' | |||
There was a problem hiding this comment.
Does this file allow comments? If so, we should link to a tracking issue.
There was a problem hiding this comment.
Per https://clang.llvm.org/extra/clang-tidy/ it looks like this is YAML, so # should work for comments.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no
clang-analyzer-osxwarnings in the iOS or macOS embedder as of #29623. Make the clang-tidy linter treat these warnings as errors so they show up locally during pre-push git hook linter.Note this still isn't running in CI for due to flutter/flutter#61661 (comment).
Pre-submit part of flutter/flutter#93279
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.