Use accessibility_config for accessibility/ax #29275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
//flutter/third_party/accessiblity/ax/ax_event_generator.cc includes the AXEventGenerator::Iterator class which subclasses std::iterator, which triggers an MSVC C++17 deprecation warning. This warning, can be suppressed by defining _SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING which is already done in the accessibility_config config. Also updates the TODO to reference the issue tracking the cleanup and removal of that definition. Issue: flutter/flutter#92229
stuartmorgan
approved these changes
Oct 21, 2021
| "//flutter/shell/platform/common:common_cpp_accessibility", | ||
| "//flutter/third_party/accessibility/*", |
There was a problem hiding this comment.
Isn't this just a more fragile way of writing :*?
There was a problem hiding this comment.
:* selects just the targets within this package, but /* selects sub-packages as well -- in this case targets in the ax subdirectory. As an alternative, I could select just that one subdirectory in addition to :*.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2021
kylinchen
pushed a commit
to XianyuTech/engine
that referenced
this pull request
Oct 22, 2021
//flutter/third_party/accessiblity/ax/ax_event_generator.cc includes the AXEventGenerator::Iterator class which subclasses std::iterator, which triggers an MSVC C++17 deprecation warning. This warning, can be suppressed by defining _SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING which is already done in the accessibility_config config. Also updates the TODO to reference the issue tracking the cleanup and removal of that definition. Issue: flutter/flutter#92229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//flutter/third_party/accessiblity/ax/ax_event_generator.cc includes the
AXEventGenerator::Iterator class which subclasses std::iterator, which
triggers an MSVC C++17 deprecation warning. This warning, can be
suppressed by defining _SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING
which is already done in the accessibility_config config.
Also updates the TODO to reference the issue tracking the cleanup and
removal of that definition.
Issue: flutter/flutter#92229
Issue: flutter/flutter#77838
This is pre-factoring for an upcoming a11y patch.
No tests added since no code is changed.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.