[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on clang tidy error for underscores in Google tests #37700

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

jmagman
Copy link
Member
@jmagman jmagman commented Nov 17, 2022

Turn on google-readability-avoid-underscore-in-googletest-name clang-tidy warning and fix violations.

https://google.github.io/googletest/faq.html#why-should-test-suite-names-and-test-names-not-contain-underscore

Example:

/b/s/w/ir/cache/builder/src/flutter/shell/platform/embedder/tests/embedder_unittests.cc:1641:1: error: avoid using "_" in test name "SoftwareRenderingPixelFormats_draw_solid_red_kRGB565" according to Googletest FAQ [google-readability-avoid-underscore-in-googletest-name,-warnings-as-errors]
SW_PIXFMT_TEST_F(draw_solid_red, kRGB565, (uint16_t)0xF800);
^
/b/s/w/ir/cache/builder/src/flutter/shell/platform/embedder/tests/embedder_unittests.cc:1634:10: note: expanded from macro 'SW_PIXFMT_TEST_F'
         SoftwareRenderingPixelFormats_##dart_entrypoint##_##pixfmt) {    \
         ^
note: expanded from here

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8797288801511583249/+/u/test:_lint_host_debug/stdout

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Nov 17, 2022
@flutter-dashboard flutter-dashboard bot added the embedder Related to the embedder API label Nov 17, 2022
Copy link
Contributor
@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 17, 2022
@auto-submit auto-submit bot merged commit 9f7e3ae into flutter:main Nov 17, 2022
@jmagman jmagman deleted the underscore branch November 17, 2022 21:17
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 17, 2022
…115598)

* 9f7e3aed7 Turn on clang tidy error for underscores in Google tests (flutter/engine#37700)

* b65c24ce6 Add semantics constants to the exported symbols list for the embedder library (flutter/engine#37526)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…lutter#115598)

* 9f7e3aed7 Turn on clang tidy error for underscores in Google tests (flutter/engine#37700)

* b65c24ce6 Add semantics constants to the exported symbols list for the embedder library (flutter/engine#37526)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#115598)

* 9f7e3aed7 Turn on clang tidy error for underscores in Google tests (flutter/engine#37700)

* b65c24ce6 Add semantics constants to the exported symbols list for the embedder library (flutter/engine#37526)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App embedder Related to the embedder API
Projects
None yet
4 participants