[Impeller] Move GetSecondsElapsed to Playground #38375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Dec 17, 2022
impeller/playground/playground.h
Outdated
| @@ -9,6 +9,7 @@ | |||
| #include "flutter/fml/closure.h" | |||
| #include "flutter/fml/macros.h" | |||
|
|
|||
| #include "fml/time/time_delta.h" | |||
There was a problem hiding this comment.
nit: Group with the fml includes above and prefix with "flutter/".
710e6c6
to
91c5068
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 17, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 17, 2022
…117270) * 1ae4c7c35 [Impeller Scene] Fix crasher for nodes with no meshes (flutter/engine#38374) * 7e296985f [Impeller] Move GetSecondsElapsed to Playground (flutter/engine#38375)
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Jan 3, 2023
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#117270) * 1ae4c7c35 [Impeller Scene] Fix crasher for nodes with no meshes (flutter/engine#38374) * 7e296985f [Impeller] Move GetSecondsElapsed to Playground (flutter/engine#38375)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlaygroundTest isn't the right abstraction for time utils like this.