[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gn + codesign] add metadata for path ops #39698

Merged
merged 3 commits into from
Feb 28, 2023
Merged

[gn + codesign] add metadata for path ops #39698

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ded70dc
add metadata for path ops
XilaiZhang Feb 17, 2023
e9a971f
add ops
XilaiZhang Feb 17, 2023
e77a186
Merge remote-tracking branch 'upstream/main' into xilaizhang-ops-1
XilaiZhang Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build/archives/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ generated_file("artifacts_entitlement_config") {
"//flutter/impeller/compiler:impellerc",
"//flutter/impeller/tessellator:tessellator_shared",
"//flutter/shell/testing:testing",
"//flutter/tools/path_ops:path_ops",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to add this dep?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah this dependency is needed to collect the metadata from tools/path_ops/BUILD.gn.

we defined a data_keys field in this target. So that if a matching data key is present in tools/path_ops/BUILD.gn, it is propagated and collected into the meta data file.

]
}
}
Expand Down
4 changes: 4 additions & 0 deletions tools/path_ops/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,8 @@ shared_library("path_ops") {
":path_ops_license",
"//third_party/skia",
]

metadata = {
entitlement_file_path = [ "libpath_ops.dylib" ]
}
}