[impeller] if not creating mipmaps dont set mip count #40513
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -323,7 +323,8 @@ sk_sp<DlImage> ImageDecoderImpeller::UploadTextureToShared( | |||
| texture_descriptor.storage_mode = impeller::StorageMode::kHostVisible; | |||
| texture_descriptor.format = pixel_format.value(); | |||
| texture_descriptor.size = {image_info.width(), image_info.height()}; | |||
| texture_descriptor.mip_count = texture_descriptor.size.MipCount(); | |||
| texture_descriptor.mip_count = | |||
| create_mips ? texture_descriptor.size.MipCount() : 1; | |||
There was a problem hiding this comment.
For my edification, why isn't the texture desciptor telling us the MipCount is 1 here?
There was a problem hiding this comment.
I added a code path to disable mipmap creation for certain texture uploads. So even though this texture may be big enough to support 3 miplevels we may not want to create them
…ter/engine#40513) (#123182) Roll Flutter Engine from 9a742fa4eaf2 to 51082515db18 (1 revision)
…unt (flutter/engine#40513) (#123182) Commit: b382c8ca36e189230d9bfd390c5206a3cad373c6
Makes the gifs/webp show up on Pixel 6 running impeller gles