[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] Enable playgrounds using a runtime instead of a build time flag. #40729

Merged
merged 1 commit into from
Mar 29, 2023
Merged

[Impeller] Enable playgrounds using a runtime instead of a build time flag. #40729

merged 1 commit into from
Mar 29, 2023

Conversation

chinmaygarde
Copy link
Member

Specify --enable_playground to impeller_unittests or any playground
enabled test harness.

@chinmaygarde
Copy link
Member Author

Builds on top of #40728 and will land after it.

@chinmaygarde chinmaygarde self-assigned this Mar 28, 2023
@chinmaygarde
[Impeller] Enable playgrounds using a runtime instead of a build time…
64bb9e5 
… flag.

Specify `--enable_plauground` to `impeller_unittests` or any playground
enabled test harness.
@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 29, 2023
@auto-submit auto-submit bot merged commit 86d5521 into flutter:main Mar 29, 2023
@chinmaygarde chinmaygarde deleted the playgroundnogn branch March 29, 2023 06:34
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
86d5521f5 [Impeller] Enable playgrounds using a runtime instead of a …
3847772 
…build time flag. (flutter/engine#40729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
86d5521f5 [Impeller] Enable playgrounds using a runtime instead of a …
ff049c3 
…build time flag. (flutter/engine#40729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
86d5521f5 [Impeller] Enable playgrounds using a runtime instead of a …
f6e18ed 
…build time flag. (flutter/engine#40729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
86d5521f5 [Impeller] Enable playgrounds using a runtime instead of a …
28cd5a3 
…build time flag. (flutter/engine#40729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
86d5521f5 [Impeller] Enable playgrounds using a runtime instead of a …
c837557 
…build time flag. (flutter/engine#40729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
86d5521f5 [Impeller] Enable playgrounds using a runtime instead of a …
2d85daa 
…build time flag. (flutter/engine#40729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
86d5521f5 [Impeller] Enable playgrounds using a runtime instead of a …
f465a1f 
…build time flag. (flutter/engine#40729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
86d5521f5 [Impeller] Enable playgrounds using a runtime instead of a …
7dfa357 
…build time flag. (flutter/engine#40729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
86d5521f5 [Impeller] Enable playgrounds using a runtime instead of a …
3688d3f 
…build time flag. (flutter/engine#40729)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
86d5521f5 [Impeller] Enable playgrounds using a runtime instead of a …
3afb0be 
…build time flag. (flutter/engine#40729)
@chinmaygarde chinmaygarde restored the playgroundnogn branch June 16, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdero bdero bdero approved these changes

@gaaclarke gaaclarke gaaclarke approved these changes

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees

@chinmaygarde chinmaygarde

Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
3 participants
@chinmaygarde @bdero @gaaclarke