[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiView changes for dart:ui #42493

Merged
merged 5 commits into from
Jun 2, 2023
Merged

Conversation

goderbauer
Copy link
Member
@goderbauer goderbauer commented Jun 1, 2023

Fixes flutter/flutter#124991.

Framework tests are failing because I need to do a pre-migration of flutter_test for the Object -> int change of viewId. That's in flutter/flutter#128092.

@flutter-dashboard flutter-dashboard bot added embedder Related to the embedder API platform-web Code specifically for the web engine labels Jun 1, 2023
@goderbauer goderbauer marked this pull request as ready for review June 1, 2023 23:35
lib/ui/pointer.dart Outdated Show resolved Hide resolved
Copy link
Member
@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this 🎉

auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 2, 2023
@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 2, 2023
@auto-submit auto-submit bot merged commit fce6978 into flutter:main Jun 2, 2023
25 checks passed
@goderbauer goderbauer deleted the multiViewDartUI branch June 2, 2023 21:33
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 2, 2023
@goderbauer
Copy link
Member Author

Another framework pre-migration for this change is landing in flutter/flutter#128152.

goderbauer added a commit to flutter/flutter that referenced this pull request Jun 3, 2023
goderbauer pushed a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 3, 2023
goderbauer pushed a commit to flutter/flutter that referenced this pull request Jun 3, 2023
…128158)

flutter/engine@8769e9c...5429372

2023-06-03 jonahwilliams@google.com [Impeller] Fix 1-d grid computation
for compute (flutter/engine#42516)
2023-06-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
PuYA-6NVHeHPlkCdk... to VtLnfLmVda1_h1AtM... (flutter/engine#42529)
2023-06-02 chris@bracken.jp [macOS] Top-left origin for PlatformView
container (flutter/engine#42523)
2023-06-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
9d8df2a5210b to d198f84f5e4e (1 revision) (flutter/engine#42527)
2023-06-02 flar@google.com Revert "Reland "add non-rendering operation
culling to DisplayListBuilder" (#41463)" (flutter/engine#42525)
2023-06-02 godofredoc@google.com Move benchmarks no upload to staging.
(flutter/engine#42524)
2023-06-02 mdebbar@google.com [web] Support platform view creation
params (flutter/engine#42255)
2023-06-02 goderbauer@google.com MultiView changes for dart:ui
(flutter/engine#42493)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from PuYA-6NVHeHP to VtLnfLmVda1_

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 5, 2023
auto-submit bot pushed a commit that referenced this pull request Jun 5, 2023
Follow-up to #42493.

The framework has been migrated to the new onSemanticsActionEvent callback.
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 6, 2023
goderbauer added a commit to flutter/flutter that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App embedder Related to the embedder API platform-web Code specifically for the web engine
Projects
None yet
2 participants