-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecations to PlatformMessage stuff #42580
Add deprecations to PlatformMessage stuff #42580
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
From PR review triage: It looks like this PR is still WIP. |
8bd4dcd
to
3dfee51
Compare
3dfee51
to
71f2af3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, I'd totally forgotten there was anything left to do from that migration! |
There is a deprecated use in one of the plugins. So a fix needs to be made in the plugin, and the fix rolled to the framework: Running command: "dart analyze --fatal-infos" in /b/s/w/ir/x/t/flutter_packages.OLSFGK/packages/url_launcher/url_launcher_platform_interface info - lib/link.dart:96:12 - 'onPlatformMessage' is deprecated and shouldn't be used. Migrate to ChannelBuffers.setListener instead. This feature was deprecated after v3.11.0-20.0.pre. Try replacing the use of the deprecated member with the replacement. - deprecated_member_use |
There is also no section with migration instructions for these deprecations added to https://docs.flutter.dev/release/breaking-changes#not-yet-released-to-stable |
This reverts commit cfbd7c7.
This reverts commit cfbd7c7. (poke)
Sorry for the disruption! The package is getting fixed up in flutter/packages#4233. |
…129029) flutter/engine@fb5fed4...aefe104 2023-06-16 30870216+gaaclarke@users.noreply.github.com Revert "Add deprecations to PlatformMessage stuff" (flutter/engine#42921) 2023-06-16 jakemac@google.com add dart_internal override where necessary (flutter/engine#42920) 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from d43262e90f25 to a4ad5b369313 (3 revisions) (flutter/engine#42919) 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from 9ab04a53b7be to d43262e90f25 (5 revisions) (flutter/engine#42918) 2023-06-16 mdebbar@google.com [web] Move webOnlyAssetManager to `dart:ui_web` (flutter/engine#42642) 2023-06-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from E5G7PwYbRA-u-ZJ9F... to -NW1eatBbmjvLaIcV... (flutter/engine#42915) 2023-06-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from FJPPnZP9EcGLQ0OZa... to fXVcR5tdj5wSd_OUz... (flutter/engine#42912) 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from c29ecbe7fba7 to 9ab04a53b7be (1 revision) (flutter/engine#42910) 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from 504a26e85fc6 to c29ecbe7fba7 (1 revision) (flutter/engine#42909) 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from f0410a265d2b to 504a26e85fc6 (1 revision) (flutter/engine#42907) 2023-06-16 godofredoc@google.com Set xcode explicitly on mac builds with release_build. (flutter/engine#42898) 2023-06-16 scheglov@google.com Fix prefer_final_in_for_each (flutter/engine#42899) 2023-06-16 skia-flutter-autoroll@skia.org Roll Skia from abfa3505db23 to f0410a265d2b (1 revision) (flutter/engine#42904) 2023-06-16 godofredoc@google.com Remove release_build from clang_tidy build. (flutter/engine#42900) 2023-06-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 53EjCyuRu91oFTBf2... to E5G7PwYbRA-u-ZJ9F... (flutter/engine#42897) 2023-06-15 chillers@google.com Revert "Roll Clang from 6d667d4b261e to 7f374b6902fa" (flutter/engine#42896) 2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from 2ab2678058a3 to abfa3505db23 (1 revision) (flutter/engine#42894) 2023-06-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from P7QA6bfO_Ij5dre7B... to FJPPnZP9EcGLQ0OZa... (flutter/engine#42892) 2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from 794b6f9240a8 to 2ab2678058a3 (6 revisions) (flutter/engine#42889) 2023-06-15 goderbauer@google.com Add deprecations to PlatformMessage stuff (flutter/engine#42580) 2023-06-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Joined obligatory vulkan swapchain submits (flutter/engine#42865) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 53EjCyuRu91o to -NW1eatBbmjv fuchsia/sdk/core/mac-amd64 from P7QA6bfO_Ij5 to fXVcR5tdj5wS If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This reverts commit aefe104. This is a straight reland without any additional changes. The package that was still using the outdated API causing the original revert has been updated in flutter/packages#4233. **Do not land this until that PR has rolled into the framework.**
Fixes old TODOs originally added in #22181.
The framework appears to be fully migrated off these.