-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide some log lines from release builds #44073
Conversation
These lines are appearing in framework tests but do not appear to have significant diagnostic value.
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
test-exempt: essentially this is code removal, i guess? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…131439) flutter/engine@9a935ec...284771d 2023-07-27 jonahwilliams@google.com Revert "[engine] disable picture complexity raster caching" (flutter/engine#44026) 2023-07-27 jonahwilliams@google.com [Impeller] Move glyph atlas state from context into lazy glyph atlas. (flutter/engine#43748) 2023-07-27 ian@hixie.ch Hide some log lines from release builds (flutter/engine#44073) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#131439) flutter/engine@9a935ec...284771d 2023-07-27 jonahwilliams@google.com Revert "[engine] disable picture complexity raster caching" (flutter/engine#44026) 2023-07-27 jonahwilliams@google.com [Impeller] Move glyph atlas state from context into lazy glyph atlas. (flutter/engine#43748) 2023-07-27 ian@hixie.ch Hide some log lines from release builds (flutter/engine#44073) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#131439) flutter/engine@9a935ec...284771d 2023-07-27 jonahwilliams@google.com Revert "[engine] disable picture complexity raster caching" (flutter/engine#44026) 2023-07-27 jonahwilliams@google.com [Impeller] Move glyph atlas state from context into lazy glyph atlas. (flutter/engine#43748) 2023-07-27 ian@hixie.ch Hide some log lines from release builds (flutter/engine#44073) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
These lines are appearing in framework tests but do not appear to have significant diagnostic value.
These lines are appearing in framework tests but do not appear to have significant diagnostic value.